Changeset 230747 in webkit

Timestamp:

Apr 17, 2018, 8:07:10 PM (8 years ago)

Author:

Conrad Shultz

Message:

WebKit::DisplayLink maintains a strong reference to WebPageProxy, creating a reference cycle
​https://bugs.webkit.org/show_bug.cgi?id=184718

Reviewed by Tim Horton.

It turns out that the m_webPageProxy back-reference in DisplayLink, which was creating a
reference cycle, wasn't ever read, so we can just remove it.

• UIProcess/mac/DisplayLink.cpp:

(WebKit::DisplayLink::DisplayLink):

• UIProcess/mac/DisplayLink.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/DisplayLink.cpp (modified) (1 diff)
• UIProcess/mac/DisplayLink.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-17  Conrad Shultz  <conrad_shultz@apple.com>
+
+        WebKit::DisplayLink maintains a strong reference to WebPageProxy, creating a reference cycle
+        https://bugs.webkit.org/show_bug.cgi?id=184718
+
+        Reviewed by Tim Horton.
+
+        It turns out that the m_webPageProxy back-reference in DisplayLink, which was creating a
+        reference cycle, wasn't ever read, so we can just remove it.
+
+        * UIProcess/mac/DisplayLink.cpp:
+        (WebKit::DisplayLink::DisplayLink):
+        * UIProcess/mac/DisplayLink.h:
+
 2018-04-17  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/mac/DisplayLink.cpp

@@ -37 +37 @@
     
 DisplayLink::DisplayLink(WebCore::PlatformDisplayID displayID, WebPageProxy& webPageProxy)
-    : m_webPageProxy(webPageProxy)
 {
     RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));

trunk/Source/WebKit/UIProcess/mac/DisplayLink.h

@@ -50 +50 @@
     
     CVDisplayLinkRef m_displayLink { nullptr };
-    Ref<WebPageProxy> m_webPageProxy;
     HashSet<unsigned> m_observers;
 };