Changeset 230783 in webkit

Timestamp:

Apr 18, 2018, 2:26:05 PM (8 years ago)

Author:

youenn@apple.com

Message:

NetworkResourceLoader should not clean itself inside didReceiveResponse
​https://bugs.webkit.org/show_bug.cgi?id=184754

Reviewed by Chris Dumez.

Delay the cleanup to after the didReceiveResponse call so that NetworkLoad can terminate its work.
Covered by XHR sync tests no longer crashing on GuardMalloc bots.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/NetworkResourceLoader.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-18  Youenn Fablet  <youenn@apple.com>
+
+        NetworkResourceLoader should not clean itself inside didReceiveResponse
+        https://bugs.webkit.org/show_bug.cgi?id=184754
+
+        Reviewed by Chris Dumez.
+
+        Delay the cleanup to after the didReceiveResponse call so that NetworkLoad can terminate its work.
+        Covered by XHR sync tests no longer crashing on GuardMalloc bots.
+
+        * NetworkProcess/NetworkResourceLoader.cpp:
+        (WebKit::NetworkResourceLoader::didReceiveResponse):
+
 2018-04-18  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp

@@ -342 +342 @@
             m_synchronousLoadData->error = WTFMove(error);
             sendReplyToSynchronousRequest(*m_synchronousLoadData, nullptr);
-            cleanup();
+            RunLoop::main().dispatch([protectedThis = makeRef(*this)]() {
+                protectedThis->cleanup();
+            });
             return ShouldContinueDidReceiveResponse::No;
         }