Changeset 231762 in webkit

Timestamp:

May 14, 2018 10:18:05 AM (6 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] timeClip(-0) should produce +0
​https://bugs.webkit.org/show_bug.cgi?id=185589

Reviewed by Saam Barati.

JSTests:

Fix several test262 failures.

• stress/date-negative-zero.js: Added.

(shouldBe):

• test262/expectations.yaml:

Source/WTF:

According to the spec[1], timeClip(-0) should produce +0.
We achieve this by adding 0.0 to the result of trunc(t).

[1]: ​https://tc39.github.io/ecma262/#sec-timeclip

• wtf/DateMath.cpp:

(WTF::timeClip):

LayoutTests:

• sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/date-negative-zero.js (added)
• JSTests/test262/expectations.yaml (modified) (2 diffs)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt (modified) (1 diff)
• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/DateMath.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [JSC] timeClip(-0) should produce +0
+        https://bugs.webkit.org/show_bug.cgi?id=185589
+
+        Reviewed by Saam Barati.
+
+        Fix several test262 failures.
+
+        * stress/date-negative-zero.js: Added.
+        (shouldBe):
+        * test262/expectations.yaml:
+
 2018-05-13  Caio Lima  <ticaiolima@gmail.com>
 

trunk/JSTests/test262/expectations.yaml

@@ -959 +959 @@
   default: 'Test262Error: Expected a TypeError but got a RangeError'
   strict mode: 'Test262Error: Expected a TypeError but got a RangeError'
-test/built-ins/Date/TimeClip_negative_zero.js:
-  default: 'Test262Error: TimeClip does not return negative zero Expected SameValue(«0», «0») to be true'
-  strict mode: 'Test262Error: TimeClip does not return negative zero Expected SameValue(«0», «0») to be true'
 test/built-ins/Date/UTC/return-value.js:
   default: 'Test262Error: 1970 Expected SameValue(«NaN», «0») to be true'
@@ -974 +971 @@
   default: 'TypeError: Type error'
   strict mode: 'TypeError: Type error'
-test/built-ins/Date/prototype/getTime/this-value-valid-date.js:
-  default: 'Test262Error: -0 Expected SameValue(«0», «0») to be true'
-  strict mode: 'Test262Error: -0 Expected SameValue(«0», «0») to be true'
 test/built-ins/Error/proto-from-ctor-realm.js:
   default: 'Test262Error: Expected SameValue(«Error», «Error») to be true'

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [JSC] timeClip(-0) should produce +0
+        https://bugs.webkit.org/show_bug.cgi?id=185589
+
+        Reviewed by Saam Barati.
+
+        * sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt:
+
 2018-05-14  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt

@@ -1 +1 @@
 S15.9.1.14_D1
 
-#1: TimeClip returns (ToInteger(value))
+#1: TimeClip returns (ToInteger(value) + (+0))
 PASS 
 

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [JSC] timeClip(-0) should produce +0
+        https://bugs.webkit.org/show_bug.cgi?id=185589
+
+        Reviewed by Saam Barati.
+
+        According to the spec[1], timeClip(-0) should produce +0.
+        We achieve this by adding 0.0 to the result of trunc(t).
+
+        [1]: https://tc39.github.io/ecma262/#sec-timeclip
+
+        * wtf/DateMath.cpp:
+        (WTF::timeClip):
+
 2018-05-13  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/WTF/wtf/DateMath.cpp

@@ -1160 +1160 @@
     if (fabs(t) > maxECMAScriptTime)
         return std::numeric_limits<double>::quiet_NaN();
-    return trunc(t);
+    return trunc(t) + 0.0;
 }