Changeset 231814 in webkit

Timestamp:

May 15, 2018 1:38:01 PM (6 years ago)

Author:

dino@apple.com

Message:

Provide UIView and UIImage for zoom transition
​https://bugs.webkit.org/show_bug.cgi?id=185655
<rdar://problem/40267224>

Reviewed by Antoine Quint.

Provide a UIView* for the frameForPreviewItem to use as a source view.
Also implement the transitionImageForPreviewItem delegate, even though
we're returning nil.

• UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:

(-[_WKPreviewControllerDelegate previewController:frameForPreviewItem:inSourceView:]):
(-[_WKPreviewControllerDelegate previewController:transitionImageForPreviewItem:contentRect:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/SystemPreviewControllerCocoa.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-05-15  Dean Jackson  <dino@apple.com>
+
+        Provide UIView and UIImage for zoom transition
+        https://bugs.webkit.org/show_bug.cgi?id=185655
+        <rdar://problem/40267224>
+
+        Reviewed by Antoine Quint.
+
+        Provide a UIView* for the frameForPreviewItem to use as a source view.
+        Also implement the transitionImageForPreviewItem delegate, even though
+        we're returning nil.
+
+        * UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:
+        (-[_WKPreviewControllerDelegate previewController:frameForPreviewItem:inSourceView:]):
+        (-[_WKPreviewControllerDelegate previewController:transitionImageForPreviewItem:contentRect:]):
+
 2018-05-15  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm

@@ -138 +138 @@
         return CGRectZero;
 
+    *view = presentingViewController.view;
     CGRect frame = presentingViewController.view.frame;
     // Create a smaller rectangle centered in the frame.
@@ -146 +147 @@
 }
 
+- (UIImage *)previewController:(QLPreviewController *)controller transitionImageForPreviewItem:(id <QLPreviewItem>)item contentRect:(CGRect *)contentRect
+{
+    return nil;
+}
+
 @end