Changeset 231896 in webkit

Timestamp:

May 17, 2018 7:29:46 AM (6 years ago)

Author:

Alan Bujtas

Message:

Add ASSERT_NOT_IMPLEMENTED_YET() macro
​https://bugs.webkit.org/show_bug.cgi?id=185713

Reviewed by Antti Koivisto.

To mark unimplemented code paths.

• wtf/Assertions.cpp:
• wtf/Assertions.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Assertions.cpp (modified) (1 diff)
• wtf/Assertions.h (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-05-17  Zalan Bujtas  <zalan@apple.com>
+
+        Add ASSERT_NOT_IMPLEMENTED_YET() macro
+        https://bugs.webkit.org/show_bug.cgi?id=185713
+
+        Reviewed by Antti Koivisto.
+
+        To mark unimplemented code paths.
+
+        * wtf/Assertions.cpp:
+        * wtf/Assertions.h:
+
 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
 

trunk/Source/WTF/wtf/Assertions.cpp

@@ -200 +200 @@
 }
 
+void WTFReportNotImplementedYet(const char* file, int line, const char* function)
+{
+    printf_stderr_common("NOT IMPLEMENTED YET\n");
+    printCallSite(file, line, function);
+}
+
 void WTFReportAssertionFailure(const char* file, int line, const char* function, const char* assertion)
 {

trunk/Source/WTF/wtf/Assertions.h

@@ -181 +181 @@
 #endif
 
+WTF_EXPORT_PRIVATE void WTFReportNotImplementedYet(const char* file, int line, const char* function);
 WTF_EXPORT_PRIVATE void WTFReportAssertionFailure(const char* file, int line, const char* function, const char* assertion);
 WTF_EXPORT_PRIVATE void WTFReportAssertionFailureWithMessage(const char* file, int line, const char* function, const char* assertion, const char* format, ...) WTF_ATTRIBUTE_PRINTF(5, 6);
@@ -278 +279 @@
 #define ASSERT_AT(assertion, file, line, function) ((void)0)
 #define ASSERT_NOT_REACHED() ((void)0)
+#define ASSERT_NOT_IMPLEMENTED_YET() ((void)0)
 #define ASSERT_IMPLIES(condition, assertion) ((void)0)
 #define NO_RETURN_DUE_TO_ASSERT
@@ -314 +316 @@
 #define ASSERT_NOT_REACHED() do { \
     WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, 0); \
+    CRASH(); \
+} while (0)
+
+#define ASSERT_NOT_IMPLEMENTED_YET() do { \
+    WTFReportNotImplementedYet(__FILE__, __LINE__, WTF_PRETTY_FUNCTION); \
     CRASH(); \
 } while (0)