⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 232144 in webkit


Ignore:
Timestamp:
May 23, 2018, 9:08:43 PM (8 years ago)
Author:
Chris Dumez
Message:

Regression(r229831): fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=183885
<rdar://problem/38733968>

Reviewed by Youenn Fablet.

Stop loading an external URL as this is not what the test is testing and since the error message for
the external load causes flakiness.

  • TestExpectations:
  • fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt:
  • fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html:
  • fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt:
  • fast/loader/javascript-url-iframe-remove-on-navigate.html:
Location:
trunk/LayoutTests
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r232123 r232144  
     12018-05-23  Chris Dumez  <cdumez@apple.com>
     2
     3        Regression(r229831): fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=183885
     5        <rdar://problem/38733968>
     6
     7        Reviewed by Youenn Fablet.
     8
     9        Stop loading an external URL as this is not what the test is testing and since the error message for
     10        the external load causes flakiness.
     11
     12        * TestExpectations:
     13        * fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt:
     14        * fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html:
     15        * fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt:
     16        * fast/loader/javascript-url-iframe-remove-on-navigate.html:
     17
    1182018-05-23  Chris Dumez  <cdumez@apple.com>
    219

  • trunk/LayoutTests/TestExpectations

    r232121 r232144  
    19771977media/event-queue-crash.html [ DumpJSConsoleLogInStdErr ]
    19781978
    1979 # This is flaky since r229831.
    1980 webkit.org/b/183885 fast/loader/javascript-url-iframe-remove-on-navigate.html [ Pass Failure ]
    1981 webkit.org/b/183885 fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html [ Pass Failure ]
    1982 
    19831979webkit.org/b/172243 imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm [ Pass Failure ]
    19841980

  • trunk/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate-expected.txt

    r229579 r232144  
    1 Blocked access to external URL http://does.not.exist/
    21PASS - Javascript URL blocked without crashing.

  • trunk/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-async-delegate.html

    r229579 r232144  
    1 <iframe src="http://does.not.exist/" id="target"></iframe>
     1<iframe src="resources/empty-subframe.html" id="target"></iframe>
    22<script>
    33if (window.testRunner) {

  • trunk/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt

    r115646 r232144  
    1 Blocked access to external URL http://does.not.exist/
    21PASS - Javascript URL blocked without crashing.

  • trunk/LayoutTests/fast/loader/javascript-url-iframe-remove-on-navigate.html

    r229579 r232144  
    1 <iframe src="http://does.not.exist/" id="target"></iframe>
     1<iframe src="resources/empty-subframe.html" id="target"></iframe>
    22<script>
    33if (window.testRunner) {
Note: See TracChangeset for help on using the changeset viewer.