Changeset 233181 in webkit

Timestamp:

Jun 25, 2018 4:40:52 PM (6 years ago)

Author:

timothy_horton@apple.com

Message:

WKThumbnailView fallback background is blindingly bright in Dark Mode
​https://bugs.webkit.org/show_bug.cgi?id=187017
<rdar://problem/41036209>

Reviewed by Simon Fraser.

• UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView initWithFrame:]):
(-[_WKThumbnailView wantsUpdateLayer]):
(-[_WKThumbnailView updateLayer]):
Use a semantic color for the WKThumbnailView background color
instead of flat white.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/_WKThumbnailView.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-06-25  Tim Horton  <timothy_horton@apple.com>
+
+        WKThumbnailView fallback background is blindingly bright in Dark Mode
+        https://bugs.webkit.org/show_bug.cgi?id=187017
+        <rdar://problem/41036209>
+
+        Reviewed by Simon Fraser.
+
+        * UIProcess/API/Cocoa/_WKThumbnailView.mm:
+        (-[_WKThumbnailView initWithFrame:]):
+        (-[_WKThumbnailView wantsUpdateLayer]):
+        (-[_WKThumbnailView updateLayer]):
+        Use a semantic color for the WKThumbnailView background color
+        instead of flat white.
+
 2018-06-25  John Wilander  <wilander@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm

@@ -71 +71 @@
 
     self.wantsLayer = YES;
-    self.layer.backgroundColor = [NSColor whiteColor].CGColor;
     _scale = 1;
     _lastSnapshotScale = NAN;
@@ -102 +101 @@
     
     return self;
+}
+
+- (BOOL)wantsUpdateLayer
+{
+    return YES;
+}
+
+- (void)updateLayer
+{
+    [super updateLayer];
+
+    self.layer.backgroundColor = [NSColor quaternaryLabelColor].CGColor;
 }