Changeset 233190 in webkit

Timestamp:

Jun 25, 2018 9:58:42 PM (6 years ago)

Author:

dbates@webkit.org

Message:

Log a message when fetching attachment data from the status server
​https://bugs.webkit.org/show_bug.cgi?id=187032

Reviewed by Zalan Bujtas.

Currently we silently fetch from the status server an attachment when fetching
the attachment from Bugzilla fails due to an access denied error. Instead we
should emit a message when fetching data from the status server to indicate
that webkit-patch/EWS is still processing the command/trying to obtain the
patch.

• Scripts/webkitpy/common/net/statusserver.py:

(StatusServer._fetch_attachment_page):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/statusserver.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-06-25  Daniel Bates  <dabates@apple.com>
+
+        Log a message when fetching attachment data from the status server
+        https://bugs.webkit.org/show_bug.cgi?id=187032
+
+        Reviewed by Zalan Bujtas.
+
+        Currently we silently fetch from the status server an attachment when fetching
+        the attachment from Bugzilla fails due to an access denied error. Instead we
+        should emit a message when fetching data from the status server to indicate
+        that webkit-patch/EWS is still processing the command/trying to obtain the
+        patch.
+
+        * Scripts/webkitpy/common/net/statusserver.py:
+        (StatusServer._fetch_attachment_page):
+
 2018-06-25  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/net/statusserver.py

@@ -204 +204 @@
     def _fetch_attachment_page(self, action, attachment_id):
         attachment_url = '{}/attachment/{}/{}'.format(self._server_url(), action, attachment_id)
+        _log.info('Fetching: {}'.format(attachment_url))
         return self._fetch_url(attachment_url)