Changeset 233531 in webkit

Timestamp:

Jul 5, 2018, 11:36:25 AM (8 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Bindings-tests-EWS should output result in json
​https://bugs.webkit.org/show_bug.cgi?id=187330

Reviewed by David Kilzer.

• BuildSlaveSupport/ews-build/steps.py:

(RunBindingsTests): Passed --json-output parameter to run-bindings-tests.

• BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -80 +80 @@
     descriptionDone = ['bindings-tests']
     flunkOnFailure = True
-    command = ['Tools/Scripts/run-bindings-tests']
+    jsonFileName = 'bindings_test_results.json'
+    logfiles = {'json': jsonFileName}
+    command = ['Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(jsonFileName)]
 
 

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -232 +232 @@
     def setUp(self):
         self.longMessage = True
+        self.jsonFileName = 'bindings_test_results.json'
         return self.setUpBuildStep()
 
@@ -241 +242 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
-                        command=['Tools/Scripts/run-bindings-tests'],
+                        command=['Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
+                        logfiles={'json': self.jsonFileName},
                         )
             + 0,
@@ -252 +254 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
-                        command=['Tools/Scripts/run-bindings-tests'],
+                        command=['Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
+                        logfiles={'json': self.jsonFileName},
                         )
             + ExpectShell.log('stdio', stdout='FAIL: (JS) JSTestInterface.cpp')

trunk/Tools/ChangeLog

@@ +1 @@
+2018-07-05  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Bindings-tests-EWS should output result in json
+        https://bugs.webkit.org/show_bug.cgi?id=187330
+
+        Reviewed by David Kilzer.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (RunBindingsTests):  Passed --json-output parameter to run-bindings-tests.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
+
 2018-07-05  Aakash Jain  <aakash_jain@apple.com>