Changeset 233553 in webkit

Timestamp:

Jul 5, 2018, 5:40:22 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover
​https://bugs.webkit.org/show_bug.cgi?id=187363
<rdar://problem/41106306>

Patch by Olivia Barnett <​obarnett@apple.com> on 2018-07-05
Reviewed by Tim Horton.

Added extra check to prevent keyboard scrolling when the select box is open.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _scrollOffsetForEvent:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-07-05  Olivia Barnett  <obarnett@apple.com>
+
+        iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover
+        https://bugs.webkit.org/show_bug.cgi?id=187363
+        <rdar://problem/41106306>
+
+        Reviewed by Tim Horton.
+
+        Added extra check to prevent keyboard scrolling when the select box is open.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _scrollOffsetForEvent:]):
+
 2018-07-05  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -3656 +3656 @@
     if (_page->editorState().isContentEditable)
         return std::nullopt;
+    
+    if (_assistedNodeInformation.elementType == InputType::Select)
+        return std::nullopt;
 
     NSString *charactersIgnoringModifiers = event.charactersIgnoringModifiers;