Changeset 233575 in webkit

Timestamp:

Jul 6, 2018, 3:38:46 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK][WPE] REGRESSION(r233239): proxy settings not applied after r233239
​https://bugs.webkit.org/show_bug.cgi?id=187381

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2018-07-06
Reviewed by Yusuke Suzuki.

This is because the static variable for proxy settings was replaced by a NeverDestroyed, but the function is not
returning a reference, but a copy. This is causing several unit tests to fail.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::proxySettings):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/SoupNetworkSession.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][WPE] REGRESSION(r233239): proxy settings not applied after r233239
+        https://bugs.webkit.org/show_bug.cgi?id=187381
+
+        Reviewed by Yusuke Suzuki.
+
+        This is because the static variable for proxy settings was replaced by a NeverDestroyed, but the function is not
+        returning a reference, but a copy. This is causing several unit tests to fail.
+
+        * platform/network/soup/SoupNetworkSession.cpp:
+        (WebCore::proxySettings):
+
 2018-07-06  Frederic Wang  <fwang@igalia.com>
 

trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp

@@ -54 +54 @@
 }
 
-static SoupNetworkProxySettings proxySettings()
+static SoupNetworkProxySettings& proxySettings()
 {
     static NeverDestroyed<SoupNetworkProxySettings> settings;