⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 233578 in webkit


Ignore:
Timestamp:
Jul 6, 2018, 9:29:40 AM (8 years ago)
Author:
dbates@webkit.org
Message:

Remove Strong Confirmation Password button
​https://bugs.webkit.org/show_bug.cgi?id=187306
<rdar://problem/41795185>

Reviewed by Sam Weinig.

Remove support for the Strong Confirmation Password button because we never made use of it.

Source/WebCore:

  • English.lproj/Localizable.strings:
  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityIsStrongPasswordField]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::hasAutoFillStrongPasswordButton const):

  • html/HTMLTextFormControlElement.h:
  • html/TextFieldInputType.cpp:

(WebCore::autoFillButtonTypeToAccessibilityLabel):
(WebCore::autoFillButtonTypeToAutoFillButtonText):
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):

  • platform/LocalizedStrings.cpp:

(WebCore::AXAutoFillStrongConfirmationPasswordLabel): Deleted.

  • platform/LocalizedStrings.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

  • testing/Internals.cpp:

(WebCore::toAutoFillButtonType):
(WebCore::toInternalsAutoFillButtonType):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(toAutoFillButtonType):
(toWKAutoFillButtonType):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(toAutoFillButtonType):
(toWKAutoFillButtonType):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:

LayoutTests:

  • accessibility/ios-simulator/strong-password-field-expected.txt:
  • accessibility/ios-simulator/strong-password-field.html:
  • fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes-expected.html:
  • fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes.html:
  • fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes-expected.html:
  • fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes.html:
  • fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset-expected.html:
  • fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:
  • fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes-expected.html:
  • fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes.html:
  • fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes-expected.html:
  • fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes.html:
  • fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button-expected.html: Removed.
  • fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html: Removed.
  • fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button-expected.html: Removed.
  • fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button.html: Removed.
  • fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html:
  • fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html:
  • fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html:
  • fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html:
  • fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html: Removed.
  • fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt:
  • fast/forms/auto-fill-button/last-auto-fill-button-type.html:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
  • platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
  • platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
  • platform/win/TestExpectations:
  • platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
  • platform/wincairo/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
Location:
trunk
Files:
10 deleted
39 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r233566 r233578  
     12018-07-06  Daniel Bates  <dabates@apple.com>
     2
     3        Remove Strong Confirmation Password button
     4        https://bugs.webkit.org/show_bug.cgi?id=187306
     5        <rdar://problem/41795185>
     6
     7        Reviewed by Sam Weinig.
     8
     9        Remove support for the Strong Confirmation Password button because we never made use of it.
     10
     11        * accessibility/ios-simulator/strong-password-field-expected.txt:
     12        * accessibility/ios-simulator/strong-password-field.html:
     13        * fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes-expected.html:
     14        * fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes.html:
     15        * fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes-expected.html:
     16        * fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes.html:
     17        * fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset-expected.html:
     18        * fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:
     19        * fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes-expected.html:
     20        * fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes.html:
     21        * fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes-expected.html:
     22        * fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes.html:
     23        * fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button-expected.html: Removed.
     24        * fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html: Removed.
     25        * fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button-expected.html: Removed.
     26        * fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button.html: Removed.
     27        * fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html:
     28        * fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html:
     29        * fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html:
     30        * fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html:
     31        * fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html: Removed.
     32        * fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt:
     33        * fast/forms/auto-fill-button/last-auto-fill-button-type.html:
     34        * platform/gtk/TestExpectations:
     35        * platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
     36        * platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
     37        * platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
     38        * platform/win/TestExpectations:
     39        * platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
     40        * platform/wincairo/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Removed.
     41
    1422018-07-05  Carlos Garcia Campos  <cgarcia@igalia.com>
    243

  • trunk/LayoutTests/accessibility/ios-simulator/strong-password-field-expected.txt

    r230510 r233578  
    77PASS axPw1.boolAttributeValue('AXIsStrongPasswordField') is false
    88PASS axPw2.boolAttributeValue('AXIsStrongPasswordField') is true
    9 PASS axPw3.boolAttributeValue('AXIsStrongPasswordField') is true
    109PASS axPw1.stringValue is 'AXValue: ••••••••'
    1110PASS axPw2.stringValue is 'AXValue: strong password'
    12 PASS axPw3.stringValue is 'AXValue: strong confirmation password'
    1311PASS successfullyParsed is true
    1412

  • trunk/LayoutTests/accessibility/ios-simulator/strong-password-field.html

    r230510 r233578  
    1010<input id="pw1" type="password" value="password">
    1111<input id="pw2" type="password" value="strong password">
    12 <input id="pw3" type="password" value="strong confirmation password">
    1312</div>
    1413
    … …  
    2221    var pw1 = document.getElementById("pw1");
    2322    var pw2 = document.getElementById("pw2");
    24     var pw3 = document.getElementById("pw3");
    2523
    2624    if (window.internals) {
    2725        window.internals.setAutofilled(pw2, true);
    28         window.internals.setShowAutoFillButton(pw2, "StrongConfirmationPassword");
    29 
    30         window.internals.setAutofilled(pw3, true);
    31         window.internals.setShowAutoFillButton(pw3, "StrongPassword");
     26        window.internals.setShowAutoFillButton(pw2, "StrongPassword");
    3227    }
    3328
    … …  
    3530        var axPw1 = accessibilityController.accessibleElementById("pw1");
    3631        var axPw2 = accessibilityController.accessibleElementById("pw2");
    37         var axPw3 = accessibilityController.accessibleElementById("pw3");
    3832
    3933        shouldBeFalse("axPw1.boolAttributeValue('AXIsStrongPasswordField')");
    4034        shouldBeTrue("axPw2.boolAttributeValue('AXIsStrongPasswordField')");
    41         shouldBeTrue("axPw3.boolAttributeValue('AXIsStrongPasswordField')");
    4235
    4336        shouldBe("axPw1.stringValue", "'AXValue: ••••••••'");
    4437        shouldBe("axPw2.stringValue", "'AXValue: strong password'");
    45         shouldBe("axPw3.stringValue", "'AXValue: strong confirmation password'");
    4638    }
    4739   

  • trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes-expected.html

    r231517 r233578  
    1717</head>
    1818<body>
    19 <p>This tests that an autofilled Strong Password or Strong Confirmation Password decorated text field does not change appearance when its maxlength changes. It can only be tested in the test tool.</p>
     19<p>This tests that an autofilled Strong Password decorated text field does not change appearance when its maxlength changes. It can only be tested in the test tool.</p>
    2020<input type="password" value="Cupertino" maxlength="100" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
    21 <input type="password" value="Cupertino" maxlength="100" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
    2221</body>
    2322</html>

  • trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes.html

    r231517 r233578  
    2020</head>
    2121<body>
    22 <p>This tests that an autofilled Strong Password or Strong Confirmation Password decorated text field does not change appearance when its maxlength changes. It can only be tested in the test tool.</p>
     22<p>This tests that an autofilled Strong Password decorated text field does not change appearance when its maxlength changes. It can only be tested in the test tool.</p>
    2323<input type="password" value="Cupertino" maxlength="100" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
    24 <input type="password" value="Cupertino" maxlength="100" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
    2524</body>
    2625</html>

  • trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes-expected.html

    r231517 r233578  
    1717</head>
    1818<body>
    19 <p>This tests that an autofilled Strong Password or Strong Confirmation Password decorated text field does not change appearance when its minlength changes. It can only be tested in the test tool.</p>
     19<p>This tests that an autofilled Strong Password decorated text field does not change appearance when its minlength changes. It can only be tested in the test tool.</p>
    2020<input type="password" value="Cupertino" minlength="5" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
    21 <input type="password" value="Cupertino" minlength="5" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
    2221</body>
    2322</html>

  • trunk/LayoutTests/fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes.html

    r231517 r233578  
    2020</head>
    2121<body>
    22 <p>This tests that an autofilled Strong Password or Strong Confirmation Password decorated text field does not change appearance when its minlength changes. It can only be tested in the test tool.</p>
     22<p>This tests that an autofilled Strong Password decorated text field does not change appearance when its minlength changes. It can only be tested in the test tool.</p>
    2323<input type="password" value="Cupertino" minlength="5" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
    24 <input type="password" value="Cupertino" minlength="5" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
    2524</body>
    2625</html>

  • trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset-expected.html

    r231519 r233578  
    22<html>
    33<body>
    4 <p>This tests that that an autofilled Strong Password or Strong Confirmation Password decorated text field reverts to its original appearance when the form is reset. It can only be tested in the test tool.</p>
     4<p>This tests that that an autofilled Strong Password decorated text field reverts to its original appearance when the form is reset. It can only be tested in the test tool.</p>
    55<form>
    6 <input type="password" value="Cupertino">
    76<input type="password" value="Cupertino">
    87</form>

  • trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html

    r231519 r233578  
    1818</head>
    1919<body>
    20 <p>This tests that that an autofilled Strong Password or Strong Confirmation Password decorated text field reverts to its original appearance when the form is reset. It can only be tested in the test tool.</p>
     20<p>This tests that that an autofilled Strong Password decorated text field reverts to its original appearance when the form is reset. It can only be tested in the test tool.</p>
    2121<form>
    2222<input type="password" value="Cupertino" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
    23 <input type="password" value="Cupertino" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
    2423</form>
    2524</body>

  • trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes-expected.html

    r231517 r233578  
    22<html>
    33<body>
    4 <p>This tests that that an autofilled Strong Password or Strong Confirmation Password decorated text field reverts to its original appearance when its value changes. It can only be tested in the test tool.</p>
    5 <input type="password" value="">
     4<p>This tests that that an autofilled Strong Password decorated text field reverts to its original appearance when its value changes. It can only be tested in the test tool.</p>
    65<input type="password" value="">
    76</body>

  • trunk/LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes.html

    r231517 r233578  
    2020</head>
    2121<body>
    22 <p>This tests that that an autofilled Strong Password or Strong Confirmation Password decorated text field reverts to its original appearance when its value changes. It can only be tested in the test tool.</p>
     22<p>This tests that that an autofilled Strong Password decorated text field reverts to its original appearance when its value changes. It can only be tested in the test tool.</p>
    2323<input type="password" value="Cupertino" data-auto-fill-button-type="StrongPassword" data-autofilled="true">
    24 <input type="password" value="Cupertino" data-auto-fill-button-type="StrongConfirmationPassword" data-autofilled="true">
    2524</body>
    2625</html>

  • trunk/LayoutTests/fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes-expected.html

    r230851 r233578  
    22<html>
    33<body>
    4 <p>This tests that a text field decorated as a Strong Password or Strong Confirmation Password field revert to a normal text field when the type of the text field changes. It can only be tested in the test tool.</p>
    5 <input type="text" value="Cupertino">
     4<p>This tests that a text field decorated as a Strong Password field revert to a normal text field when the type of the text field changes. It can only be tested in the test tool.</p>
    65<input type="text" value="Cupertino">
    76</body>

  • trunk/LayoutTests/fast/forms/auto-fill-button/hide-strong-password-when-field-type-changes.html

    r230851 r233578  
    2020</head>
    2121<body>
    22 <p>This tests that a text field decorated as a Strong Password or Strong Confirmation Password field revert to a normal text field when the type of the text field changes. It can only be tested in the test tool.</p>
     22<p>This tests that a text field decorated as a Strong Password field revert to a normal text field when the type of the text field changes. It can only be tested in the test tool.</p>
    2323<input type="password" value="Cupertino" data-auto-fill-button-type="StrongPassword">
    24 <input type="password" value="Cupertino" data-auto-fill-button-type="StrongConfirmationPassword">
    2524</body>
    2625</html>

  • trunk/LayoutTests/fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html

    r225879 r233578  
    22<html>
    33<body>
    4 <p>This tests that the Strong Password and Strong Confirmation Password AutoFill buttons do not render in a disabled field. It can only be tested in the test tool.</p>
    5 <input type="password" placeholder="disabled" disabled>
     4<p>This tests that the Strong Password button does not render in a disabled field. It can only be tested in the test tool.</p>
    65<input type="password" placeholder="disabled" disabled>
    76</body>

  • trunk/LayoutTests/fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html

    r230851 r233578  
    55</head>
    66<body>
    7 <p>This tests that the Strong Password and Strong Confirmation Password AutoFill buttons do not render in a disabled field. It can only be tested in the test tool.</p>
     7<p>This tests that the Strong Password button does not render in a disabled field. It can only be tested in the test tool.</p>
    88<input type="password" placeholder="disabled" disabled data-auto-fill-button-type="StrongPassword">
    9 <input type="password" placeholder="disabled" disabled data-auto-fill-button-type="StrongConfirmationPassword">
    109</body>
    1110</html>

  • trunk/LayoutTests/fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html

    r225879 r233578  
    22<html>
    33<body>
    4 <p>This tests that the Strong Password and Strong Confirmation Password AutoFill buttons do not render read only field. It can only be tested in the test tool.</p>
    5 <input type="password" placeholder="read only" readonly>
     4<p>This tests that the Strong Password button does not render read only field. It can only be tested in the test tool.</p>
    65<input type="password" placeholder="read only" readonly>
    76</body>

  • trunk/LayoutTests/fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html

    r230851 r233578  
    55</head>
    66<body>
    7 <p>This tests that the Strong Password and Strong Confirmation Password AutoFill buttons do not render read only field. It can only be tested in the test tool.</p>
     7<p>This tests that the Strong Password button does not render read only field. It can only be tested in the test tool.</p>
    88<input type="password" placeholder="read only" readonly data-auto-fill-button-type="StrongPassword">
    9 <input type="password" placeholder="read only" readonly data-auto-fill-button-type="StrongConfirmationPassword">
    109</body>
    1110</html>

  • trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt

    r226048 r233578  
    1414PASS internals.autoFillButtonType(inputElement) is "StrongPassword"
    1515PASS internals.lastAutoFillButtonType(inputElement) is "Contacts"
    16 internals.setShowAutoFillButton(inputElement, 'StrongConfirmationPassword')
    17 PASS internals.autoFillButtonType(inputElement) is "StrongConfirmationPassword"
     16internals.setShowAutoFillButton(inputElement, 'Credentials')
     17PASS internals.autoFillButtonType(inputElement) is "Credentials"
    1818PASS internals.lastAutoFillButtonType(inputElement) is "StrongPassword"
    1919internals.setShowAutoFillButton(inputElement, 'None')
    2020PASS internals.autoFillButtonType(inputElement) is "None"
    21 PASS internals.lastAutoFillButtonType(inputElement) is "StrongConfirmationPassword"
     21PASS internals.lastAutoFillButtonType(inputElement) is "Credentials"
    2222PASS successfullyParsed is true
    2323

  • trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type.html

    r226048 r233578  
    2323    shouldBeEqualToString("internals.autoFillButtonType(inputElement)", "StrongPassword");
    2424    shouldBeEqualToString("internals.lastAutoFillButtonType(inputElement)", "Contacts");
    25     evalAndLog("internals.setShowAutoFillButton(inputElement, 'StrongConfirmationPassword')");
    26     shouldBeEqualToString("internals.autoFillButtonType(inputElement)", "StrongConfirmationPassword");
     25    evalAndLog("internals.setShowAutoFillButton(inputElement, 'Credentials')");
     26    shouldBeEqualToString("internals.autoFillButtonType(inputElement)", "Credentials");
    2727    shouldBeEqualToString("internals.lastAutoFillButtonType(inputElement)", "StrongPassword");
    2828    evalAndLog("internals.setShowAutoFillButton(inputElement, 'None')");
    2929    shouldBeEqualToString("internals.autoFillButtonType(inputElement)", "None");
    30     shouldBeEqualToString("internals.lastAutoFillButtonType(inputElement)", "StrongConfirmationPassword");
     30    shouldBeEqualToString("internals.lastAutoFillButtonType(inputElement)", "Credentials");
    3131}
    3232</script>

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r233556 r233578  
    33513351
    33523352webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html [ Missing Failure ]
    3353 webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html [ Missing Failure ]
    33543353
    33553354webkit.org/b/182050 http/wpt/fetch/response-opaque-clone.html [ Pass Crash ]

  • trunk/LayoutTests/platform/win/TestExpectations

    r233355 r233578  
    39453945
    39463946webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html [ Failure ]
    3947 webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html [ Failure ]
    39483947
    39493948webkit.org/b/181854 svg/filters/feDiffuseLighting-bottomRightPixel.html [ ImageOnlyFailure ]

  • trunk/Source/WebCore/ChangeLog

    r233575 r233578  
     12018-07-06  Daniel Bates  <dabates@apple.com>
     2
     3        Remove Strong Confirmation Password button
     4        https://bugs.webkit.org/show_bug.cgi?id=187306
     5        <rdar://problem/41795185>
     6
     7        Reviewed by Sam Weinig.
     8
     9        Remove support for the Strong Confirmation Password button because we never made use of it.
     10
     11        * English.lproj/Localizable.strings:
     12        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
     13        (-[WebAccessibilityObjectWrapper _accessibilityIsStrongPasswordField]):
     14        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
     15        (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
     16        * html/HTMLInputElement.h:
     17        (WebCore::HTMLInputElement::hasAutoFillStrongPasswordButton const):
     18        * html/HTMLTextFormControlElement.h:
     19        * html/TextFieldInputType.cpp:
     20        (WebCore::autoFillButtonTypeToAccessibilityLabel):
     21        (WebCore::autoFillButtonTypeToAutoFillButtonText):
     22        (WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
     23        (WebCore::isAutoFillButtonTypeChanged):
     24        * platform/LocalizedStrings.cpp:
     25        (WebCore::AXAutoFillStrongConfirmationPasswordLabel): Deleted.
     26        * platform/LocalizedStrings.h:
     27        * rendering/RenderTextControlSingleLine.cpp:
     28        (WebCore::RenderTextControlSingleLine::layout):
     29        * testing/Internals.cpp:
     30        (WebCore::toAutoFillButtonType):
     31        (WebCore::toInternalsAutoFillButtonType):
     32        * testing/Internals.h:
     33        * testing/Internals.idl:
     34
    1352018-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
    236

  • trunk/Source/WebCore/English.lproj/Localizable.strings

    r233464 r233578  
    12171217"strong password auto fill" = "strong password auto fill";
    12181218
    1219 /* Label for the strong password confirmation auto fill button inside a text field. */
    1220 "strong password confirmation auto fill" = "strong password confirmation auto fill";
    1221 
    12221219/* The suboptimal value description for a meter element. */
    12231220"suboptimal value" = "suboptimal value";

  • trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

    r233257 r233578  
    10931093        return NO;
    10941094   
    1095     AutoFillButtonType type = m_object->valueAutofillButtonType();
    1096     return type == AutoFillButtonType::StrongConfirmationPassword || type == AutoFillButtonType::StrongPassword;
     1095    return m_object->valueAutofillButtonType() == AutoFillButtonType::StrongPassword;
    10971096}
    10981097

  • trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

    r232508 r233578  
    31103110        case AutoFillButtonType::Contacts:
    31113111            return @"contacts";
    3112         case AutoFillButtonType::StrongConfirmationPassword:
    3113             return @"strong confirmation password";
    31143112        case AutoFillButtonType::StrongPassword:
    31153113            return @"strong password";

  • trunk/Source/WebCore/html/HTMLInputElement.h

    r232613 r233578  
    243243    WEBCORE_EXPORT void setShowAutoFillButton(AutoFillButtonType);
    244244
    245     bool hasAutoFillStrongPasswordButton() const  { return autoFillButtonType() == AutoFillButtonType::StrongPassword || autoFillButtonType() == AutoFillButtonType::StrongConfirmationPassword; }
     245    bool hasAutoFillStrongPasswordButton() const  { return autoFillButtonType() == AutoFillButtonType::StrongPassword; }
    246246
    247247    bool isAutoFillAvailable() const { return m_isAutoFillAvailable; }

  • trunk/Source/WebCore/html/HTMLTextFormControlElement.h

    r232335 r233578  
    3434class VisiblePosition;
    3535
    36 enum class AutoFillButtonType : uint8_t { None, Credentials, Contacts, StrongConfirmationPassword, StrongPassword };
     36enum class AutoFillButtonType : uint8_t { None, Credentials, Contacts, StrongPassword };
    3737enum TextFieldSelectionDirection { SelectionHasNoDirection, SelectionHasForwardDirection, SelectionHasBackwardDirection };
    3838enum TextFieldEventBehavior { DispatchNoEvent, DispatchChangeEvent, DispatchInputAndChangeEvent };

  • trunk/Source/WebCore/html/TextFieldInputType.cpp

    r232640 r233578  
    451451    case AutoFillButtonType::Credentials:
    452452        return AXAutoFillCredentialsLabel();
    453     case AutoFillButtonType::StrongConfirmationPassword:
    454         return AXAutoFillStrongConfirmationPasswordLabel();
    455453    case AutoFillButtonType::StrongPassword:
    456454        return AXAutoFillStrongPasswordLabel();
    … …  
    468466    case AutoFillButtonType::Contacts:
    469467    case AutoFillButtonType::Credentials:
    470     case AutoFillButtonType::StrongConfirmationPassword:
    471468        return emptyString();
    472469    case AutoFillButtonType::StrongPassword:
    … …  
    487484    case AutoFillButtonType::Credentials:
    488485        return { "-webkit-credentials-auto-fill-button", AtomicString::ConstructFromLiteral };
    489     case AutoFillButtonType::StrongConfirmationPassword:
    490         return { "-webkit-strong-confirmation-password-auto-fill-button", AtomicString::ConstructFromLiteral };
    491486    case AutoFillButtonType::StrongPassword:
    492487        return { "-webkit-strong-password-auto-fill-button", AtomicString::ConstructFromLiteral };
    … …  
    504499        return true;
    505500    if (attribute == "-webkit-credentials-auto-fill-button" && autoFillButtonType != AutoFillButtonType::Credentials)
    506         return true;
    507     if (attribute == "-webkit-strong-confirmation-password-auto-fill-button" && autoFillButtonType != AutoFillButtonType::StrongConfirmationPassword)
    508501        return true;
    509502    if (attribute == "-webkit-strong-password-auto-fill-button" && autoFillButtonType != AutoFillButtonType::StrongPassword)

  • trunk/Source/WebCore/platform/LocalizedStrings.cpp

    r232479 r233578  
    629629{
    630630    return WEB_UI_STRING("strong password auto fill", "Label for the strong password auto fill button inside a text field.");
    631 }
    632 
    633 String AXAutoFillStrongConfirmationPasswordLabel()
    634 {
    635     return WEB_UI_STRING("strong password confirmation auto fill", "Label for the strong password confirmation auto fill button inside a text field.");
    636631}
    637632

  • trunk/Source/WebCore/platform/LocalizedStrings.h

    r232479 r233578  
    217217    String AXAutoFillContactsLabel();
    218218    String AXAutoFillStrongPasswordLabel();
    219     String AXAutoFillStrongConfirmationPasswordLabel();
    220219    String autoFillStrongPasswordLabel();
    221220

  • trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp

    r232018 r233578  
    9595    //   than the intrinsic heights of the inner elements.
    9696    // - Make the height of the container element equal to the intrinsic height of
    97     //   the inner elements when the field has a strong password or strong confirmation
    98     //   password button.
     97    //   the inner elements when the field has a strong password button.
    9998    //
    10099    // We don't honor paddings and borders for textfields without decorations

  • trunk/Source/WebCore/testing/Internals.cpp

    r233563 r233578  
    17571757    case Internals::AutoFillButtonType::Contacts:
    17581758        return AutoFillButtonType::Contacts;
    1759     case Internals::AutoFillButtonType::StrongConfirmationPassword:
    1760         return AutoFillButtonType::StrongConfirmationPassword;
    17611759    case Internals::AutoFillButtonType::StrongPassword:
    17621760        return AutoFillButtonType::StrongPassword;
    … …  
    17751773    case AutoFillButtonType::Contacts:
    17761774        return Internals::AutoFillButtonType::Contacts;
    1777     case AutoFillButtonType::StrongConfirmationPassword:
    1778         return Internals::AutoFillButtonType::StrongConfirmationPassword;
    1779    case AutoFillButtonType::StrongPassword:
     1775    case AutoFillButtonType::StrongPassword:
    17801776        return Internals::AutoFillButtonType::StrongPassword;
    17811777    }

  • trunk/Source/WebCore/testing/Internals.h

    r233563 r233578  
    246246    void setEditingValue(HTMLInputElement&, const String&);
    247247    void setAutofilled(HTMLInputElement&, bool enabled);
    248     enum class AutoFillButtonType { None, Contacts, Credentials, StrongPassword, StrongConfirmationPassword };
     248    enum class AutoFillButtonType { None, Contacts, Credentials, StrongPassword };
    249249    void setShowAutoFillButton(HTMLInputElement&, AutoFillButtonType);
    250250    AutoFillButtonType autoFillButtonType(const HTMLInputElement&);

  • trunk/Source/WebCore/testing/Internals.idl

    r233563 r233578  
    6363    "Contacts",
    6464    "Credentials",
    65     "StrongPassword",
    66     "StrongConfirmationPassword"
     65    "StrongPassword"
    6766};
    6867

  • trunk/Source/WebKit/ChangeLog

    r233563 r233578  
     12018-07-06  Daniel Bates  <dabates@apple.com>
     2
     3        Remove Strong Confirmation Password button
     4        https://bugs.webkit.org/show_bug.cgi?id=187306
     5        <rdar://problem/41795185>
     6
     7        Reviewed by Sam Weinig.
     8
     9        Remove support for the Strong Confirmation Password button because we never made use of it.
     10
     11        * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
     12        (toAutoFillButtonType):
     13        (toWKAutoFillButtonType):
     14        * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:
     15        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
     16        (toAutoFillButtonType):
     17        (toWKAutoFillButtonType):
     18        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
     19
    1202018-07-05  Youenn Fablet  <youenn@apple.com>
    221

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm

    r226048 r233578  
    136136    case _WKAutoFillButtonTypeCredentials:
    137137        return WebCore::AutoFillButtonType::Credentials;
    138     case _WKAutoFillButtonTypeStrongConfirmationPassword:
    139         return WebCore::AutoFillButtonType::StrongConfirmationPassword;
    140138    case _WKAutoFillButtonTypeStrongPassword:
    141139        return WebCore::AutoFillButtonType::StrongPassword;
    … …  
    154152    case WebCore::AutoFillButtonType::Credentials:
    155153        return _WKAutoFillButtonTypeCredentials;
    156     case WebCore::AutoFillButtonType::StrongConfirmationPassword:
    157         return _WKAutoFillButtonTypeStrongConfirmationPassword;
    158154    case WebCore::AutoFillButtonType::StrongPassword:
    159155        return _WKAutoFillButtonTypeStrongPassword;

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h

    r230121 r233578  
    3232    _WKAutoFillButtonTypeCredentials,
    3333    _WKAutoFillButtonTypeContacts,
    34     _WKAutoFillButtonTypeStrongConfirmationPassword,
    3534    _WKAutoFillButtonTypeStrongPassword,
    3635} WK_API_AVAILABLE(macosx(10.13.4), ios(11.3));

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp

    r226048 r233578  
    4747    case kWKAutoFillButtonTypeCredentials:
    4848        return WebCore::AutoFillButtonType::Credentials;
    49     case kWKAutoFillButtonTypeStrongConfirmationPassword:
    50         return WebCore::AutoFillButtonType::StrongConfirmationPassword;
    5149    case kWKAutoFillButtonTypeStrongPassword:
    5250        return WebCore::AutoFillButtonType::StrongPassword;
    … …  
    6563    case WebCore::AutoFillButtonType::Credentials:
    6664        return kWKAutoFillButtonTypeCredentials;
    67     case WebCore::AutoFillButtonType::StrongConfirmationPassword:
    68         return kWKAutoFillButtonTypeStrongConfirmationPassword;
    6965    case WebCore::AutoFillButtonType::StrongPassword:
    7066        return kWKAutoFillButtonTypeStrongPassword;

  • trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h

    r226048 r233578  
    4141    kWKAutoFillButtonTypeContacts,
    4242    kWKAutoFillButtonTypeStrongPassword,
    43     kWKAutoFillButtonTypeStrongConfirmationPassword,
    4443};
    4544typedef uint8_t WKAutoFillButtonType;
Note: See TracChangeset for help on using the changeset viewer.