Changeset 234967 in webkit

Timestamp:

Aug 16, 2018 4:05:54 PM (6 years ago)

Author:

achristensen@apple.com

Message:

Remove unused allowScriptsToCloseWindows setting
​https://bugs.webkit.org/show_bug.cgi?id=188602

Reviewed by Simon Fraser.

No change in behaviour. It was always false.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::close):

• page/Settings.yaml:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMWindow.cpp (modified) (1 diff)
• page/Settings.yaml (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-08-16  Alex Christensen  <achristensen@webkit.org>
+
+        Remove unused allowScriptsToCloseWindows setting
+        https://bugs.webkit.org/show_bug.cgi?id=188602
+
+        Reviewed by Simon Fraser.
+
+        No change in behaviour. It was always false.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::close):
+        * page/Settings.yaml:
+
 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -1087 +1087 @@
         return;
 
-    bool allowScriptsToCloseWindows = m_frame->settings().allowScriptsToCloseWindows();
-
-    if (!(page->openedByDOM() || page->backForward().count() <= 1 || allowScriptsToCloseWindows)) {
+    if (!(page->openedByDOM() || page->backForward().count() <= 1)) {
         console()->addMessage(MessageSource::JS, MessageLevel::Warning, "Can't close the window since it was not opened by JavaScript"_s);
         return;

trunk/Source/WebCore/page/Settings.yaml

@@ -193 +193 @@
 usesEncodingDetector:
   initial: false
-allowScriptsToCloseWindows:
-  initial: false
 canvasUsesAcceleratedDrawing:
   initial: false