Changeset 235000 in webkit

Timestamp:

Aug 17, 2018 5:09:32 PM (6 years ago)

Author:

Brent Fulgham

Message:

Remove Adobe SSO exception now that StorageAccess API is available
​https://bugs.webkit.org/show_bug.cgi?id=188710
<rdar://problem/35056707>

Reviewed by Alex Christensen.

Remove custom quirk now that proper API exists to allow the same functions.

• loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logSubresourceLoading): Remove unneeded quirk.
(WebCore::resourceNeedsSSOQuirk): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/ResourceLoadObserver.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-08-17  Brent Fulgham  <bfulgham@apple.com>
+
+        Remove Adobe SSO exception now that StorageAccess API is available
+        https://bugs.webkit.org/show_bug.cgi?id=188710
+        <rdar://problem/35056707>
+
+        Reviewed by Alex Christensen.
+
+        Remove custom quirk now that proper API exists to allow the same functions.
+
+        * loader/ResourceLoadObserver.cpp:
+        (WebCore::ResourceLoadObserver::logSubresourceLoading): Remove unneeded quirk.
+        (WebCore::resourceNeedsSSOQuirk): Deleted.
+
 2018-08-17  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/loader/ResourceLoadObserver.cpp

@@ -105 +105 @@
 }
 
-// FIXME: This quirk was added to address <rdar://problem/33325881> and should be removed once content is fixed.
-static bool resourceNeedsSSOQuirk(Page* page, const URL& url)
-{
-    if (!shouldEnableSiteSpecificQuirks(page))
-        return false;
-
-    return equalIgnoringASCIICase(url.host(), "sp.auth.adobe.com");
-}
-
 void ResourceLoadObserver::logSubresourceLoading(const Frame* frame, const ResourceRequest& newRequest, const ResourceResponse& redirectResponse)
 {
@@ -138 +129 @@
     
     if (areDomainsAssociated(page, targetPrimaryDomain, mainFramePrimaryDomain) || (isRedirect && areDomainsAssociated(page, targetPrimaryDomain, sourcePrimaryDomain)))
-        return;
-
-    if (resourceNeedsSSOQuirk(page, targetURL))
         return;