Changeset 235268 in webkit

Timestamp:

Aug 23, 2018 7:01:29 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

initKeyboardEvent doesn't clear CapsLock state
​https://bugs.webkit.org/show_bug.cgi?id=188909

Reviewed by Wenson Hsieh.

Source/WebCore:

Fixed the bug by not preserving CapsLock state in setModifierKeys variant which takes boolean
for altGraphKey, which is only called by KeyboardEvent::initKeyboardEvent.

Test: fast/events/init-event-clears-capslock.html

• dom/UIEventWithKeyState.h:

(WebCore::UIEventWithKeyState::setModifierKeys):

LayoutTests:

Added a regression test. Note that altGraph is only supported in WebKit
so Chrome and Firefox would fail to reset it via initKeyboardEvent.

• fast/events/init-event-clears-capslock-expected.txt: Added.
• fast/events/init-event-clears-capslock.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/init-event-clears-capslock-expected.txt (added)
• LayoutTests/fast/events/init-event-clears-capslock.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/UIEventWithKeyState.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-08-23  Ryosuke Niwa  <rniwa@webkit.org>
+
+        initKeyboardEvent doesn't clear CapsLock state
+        https://bugs.webkit.org/show_bug.cgi?id=188909
+
+        Reviewed by Wenson Hsieh.
+
+        Added a regression test. Note that altGraph is only supported in WebKit
+        so Chrome and Firefox would fail to reset it via initKeyboardEvent.
+
+        * fast/events/init-event-clears-capslock-expected.txt: Added.
+        * fast/events/init-event-clears-capslock.html: Added.
+
 2018-08-23  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-08-23  Ryosuke Niwa  <rniwa@webkit.org>
+
+        initKeyboardEvent doesn't clear CapsLock state
+        https://bugs.webkit.org/show_bug.cgi?id=188909
+
+        Reviewed by Wenson Hsieh.
+
+        Fixed the bug by not preserving CapsLock state in setModifierKeys variant which takes boolean
+        for altGraphKey, which is only called by KeyboardEvent::initKeyboardEvent.
+
+        Test: fast/events/init-event-clears-capslock.html
+
+        * dom/UIEventWithKeyState.h:
+        (WebCore::UIEventWithKeyState::setModifierKeys):
+
 2018-08-23  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/Source/WebCore/dom/UIEventWithKeyState.h

@@ -77 +77 @@
         if (altGraphKey)
             result |= Modifier::AltGraphKey;
-        //  FIXME: Chrome or Firefox don't preserve this state.
-        if (m_modifiers & Modifier::CapsLockKey)
-            result |= Modifier::CapsLockKey;
         m_modifiers = result;
     }