Changeset 235357 in webkit

Timestamp:

Aug 27, 2018, 1:52:40 AM (8 years ago)

Author:

yusukesuzuki@slowstart.org

Message:

Shrink size of HTMLCollection
​https://bugs.webkit.org/show_bug.cgi?id=188945

Reviewed by Darin Adler.

Shrink the size of HTMLCollection by reordering members.

No behavior change.

• html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):

• html/HTMLCollection.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLCollection.cpp (modified) (1 diff)
• html/HTMLCollection.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-08-25  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
+
+        Shrink size of HTMLCollection
+        https://bugs.webkit.org/show_bug.cgi?id=188945
+
+        Reviewed by Darin Adler.
+
+        Shrink the size of HTMLCollection by reordering members.
+
+        No behavior change.
+
+        * html/HTMLCollection.cpp:
+        (WebCore::HTMLCollection::HTMLCollection):
+        * html/HTMLCollection.h:
+
 2018-08-25  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
 

trunk/Source/WebCore/html/HTMLCollection.cpp

@@ -109 +109 @@
 
 HTMLCollection::HTMLCollection(ContainerNode& ownerNode, CollectionType type)
-    : m_ownerNode(ownerNode)
-    , m_collectionType(type)
+    : m_collectionType(type)
     , m_invalidationType(invalidationTypeExcludingIdAndNameAttributes(type))
     , m_rootType(rootTypeFromCollectionType(type))
+    , m_ownerNode(ownerNode)
 {
     ASSERT(m_rootType == static_cast<unsigned>(rootTypeFromCollectionType(type)));

trunk/Source/WebCore/html/HTMLCollection.h

@@ -102 +102 @@
     static RootType rootTypeFromCollectionType(CollectionType);
 
-    Ref<ContainerNode> m_ownerNode;
-
-    mutable std::unique_ptr<CollectionNamedElementCache> m_namedElementCache;
     mutable Lock m_namedElementCacheAssignmentLock;
-    
+
     const unsigned m_collectionType : 5;
     const unsigned m_invalidationType : 4;
     const unsigned m_rootType : 1;
+
+    Ref<ContainerNode> m_ownerNode;
+
+    mutable std::unique_ptr<CollectionNamedElementCache> m_namedElementCache;
 };