Changeset 235504 in webkit

Timestamp:

Aug 30, 2018 7:35:27 AM (6 years ago)

Author:

Wenson Hsieh

Message:

[iOS] TestWebKitAPI.PasteImage tests are flaky failures
​https://bugs.webkit.org/show_bug.cgi?id=185965

Reviewed by Andy Estes.

These tests pass reliably when run locally, but sometimes fail in automation when checking that the image
element with its "src" attribute set to a new blob URL has an empty size. It's possible that this is happening
because we're checking the size of the image element prior to image load after setting the blob URL; we can fix
this by waiting for the "load" event (which is also done in some of the other tests in this file).

• TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:

(TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-08-30  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] TestWebKitAPI.PasteImage tests are flaky failures
+        https://bugs.webkit.org/show_bug.cgi?id=185965
+
+        Reviewed by Andy Estes.
+
+        These tests pass reliably when run locally, but sometimes fail in automation when checking that the image
+        element with its "src" attribute set to a new blob URL has an empty size. It's possible that this is happening
+        because we're checking the size of the image element prior to image load after setting the blob URL; we can fix
+        this by waiting for the "load" event (which is also done in some of the other tests in this file).
+
+        * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
+        (TEST):
+
 2018-08-30  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm

@@ -68 +68 @@
 
     [webView stringByEvaluatingJavaScript:@"insertFileAsImage(gifItem.file)"];
+    [webView waitForMessage:@"loaded"];
     EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = new URL(imageElement.src); url.protocol"]);
     EXPECT_WK_STREQ("400", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
@@ -90 +91 @@
 
     [webView stringByEvaluatingJavaScript:@"insertFileAsImage(jpegItem.file)"];
+    [webView waitForMessage:@"loaded"];
     EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = new URL(imageElement.src); url.protocol"]);
     EXPECT_WK_STREQ("600", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);
@@ -112 +114 @@
 
     [webView stringByEvaluatingJavaScript:@"insertFileAsImage(pngItem.file)"];
+    [webView waitForMessage:@"loaded"];
     EXPECT_WK_STREQ("blob:", [webView stringByEvaluatingJavaScript:@"url = new URL(imageElement.src); url.protocol"]);
     EXPECT_WK_STREQ("200", [webView stringByEvaluatingJavaScript:@"imageElement.width"]);