Changeset 23553 in webkit

Timestamp:

Jun 15, 2007, 3:07:55 PM (18 years ago)

Author:

andersca

Message:

Reviewed by Kevin.

A better fix for <rdar://problem/5271774>. Only try to access the element if the
view has an associated window. This also works with GC. (Fix suggested by Kevin.)

• Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):

Location:

trunk/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Plugins/WebKitPluginContainerView.mm (modified) (2 diffs)

trunk/WebKit/ChangeLog

@@ +1 @@
+2007-06-15  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Kevin.
+
+        A better fix for <rdar://problem/5271774>. Only try to access the element if the
+        view has an associated window. This also works with GC. (Fix suggested by Kevin.)
+
+        * Plugins/WebKitPluginContainerView.mm:
+        (-[WebKitPluginContainerView dealloc]):
+        (-[WebKitPluginContainerView visibleRect]):
+
 2007-06-15  Anders Carlsson  <andersca@apple.com>
 

trunk/WebKit/Plugins/WebKitPluginContainerView.mm

@@ -46 +46 @@
     [_element release];
     
-    // Calling [super dealloc] can end up calling visibleRect so we need to set
-    // the _element instance to 0 here so we can check for it in our visibleRect.
-    _element = 0;
-    
     [super dealloc];
 }
@@ -55 +51 @@
 - (NSRect)visibleRect
 {
-    if (!_element)
+    if (![self window])
         return [super visibleRect];