Changeset 236010 in webkit

Timestamp:

Sep 14, 2018, 10:03:35 AM (8 years ago)

Author:

jer.noble@apple.com

Message:

Turn SourceBufferChangeTypeEnabled on by default
​https://bugs.webkit.org/show_bug.cgi?id=189527

Reviewed by Eric Carlson.

Source/WebCore:

• page/Settings.yaml:

Source/WebKit:

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/Settings.yaml (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/Shared/WebPreferences.yaml (modified) (2 diffs)
• WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h (modified) (1 diff)
• WebKitLegacy/mac/ChangeLog (modified) (1 diff)
• WebKitLegacy/mac/WebView/WebPreferences.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-09-14  Jer Noble  <jer.noble@apple.com>
+
+        Turn SourceBufferChangeTypeEnabled on by default
+        https://bugs.webkit.org/show_bug.cgi?id=189527
+
+        Reviewed by Eric Carlson.
+
+        * page/Settings.yaml:
+
 2018-09-14  Devin Rousso  <webkit@devinrousso.com>
 

trunk/Source/WebCore/page/Settings.yaml

@@ -432 +432 @@
 
 sourceBufferChangeTypeEnabled:
-  initial: false
+  initial: true
   conditional: MEDIA_SOURCE
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-09-14  Jer Noble  <jer.noble@apple.com>
+
+        Turn SourceBufferChangeTypeEnabled on by default
+        https://bugs.webkit.org/show_bug.cgi?id=189527
+
+        Reviewed by Eric Carlson.
+
+        * Shared/WebPreferences.yaml:
+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
+
 2018-09-14  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebKit/Shared/WebPreferences.yaml

@@ -1125 +1125 @@
   defaultValue: true
   webcoreBinding: RuntimeEnabledFeatures
+
+SourceBufferChangeTypeEnabled:
+  type: bool
+  defaultValue: true
+  condition: ENABLE(MEDIA_SOURCE)
 
 # For experimental features:
@@ -1271 +1276 @@
   webcoreBinding: none
 
-SourceBufferChangeTypeEnabled:
-  type: bool
-  defaultValue: false
-  humanReadableName: "Media Source Codec Switching Support"
-  humanReadableDescription: "Media Source Codec Switching through changeType()"
-  category: internal
-  condition: ENABLE(MEDIA_SOURCE)
-
 ResourceLoadStatisticsDebugMode:
   type: bool

trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h

@@ -381 +381 @@
 WK_EXPORT bool WKPreferencesGetMediaSourceEnabled(WKPreferencesRef preferencesRef);
 
-// Defaults to false;
+// Defaults to true;
 WK_EXPORT void WKPreferencesSetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesGetSourceBufferChangeTypeEnabled(WKPreferencesRef preferencesRef);

trunk/Source/WebKitLegacy/mac/ChangeLog

@@ +1 @@
+2018-09-14  Jer Noble  <jer.noble@apple.com>
+
+        Turn SourceBufferChangeTypeEnabled on by default
+        https://bugs.webkit.org/show_bug.cgi?id=189527
+
+        Reviewed by Eric Carlson.
+
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+
 2018-09-12  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm

@@ -606 +606 @@
 #if ENABLE(MEDIA_SOURCE)
         [NSNumber numberWithBool:YES], WebKitMediaSourceEnabledPreferenceKey,
-        @NO, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
+        @YES, WebKitSourceBufferChangeTypeEnabledPreferenceKey,
 #endif
 #if ENABLE(SERVICE_CONTROLS)