Context Navigation

Changeset 236112 in webkit

Timestamp:

Sep 18, 2018, 2:47:47 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

Merge r235457 - Check for null renderer in canBeScrolledIntoView
https://bugs.webkit.org/show_bug.cgi?id=188935

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/spatial-navigation/snav-display-contents-crash.html

(WebCore::canBeScrolledIntoView):

LayoutTests:

Location:

releases/WebKitGTK/webkit-2.22

Files:

-              r236110
+              r236112
+-08-28  Don Olmstead  <don.olmstead@sony.com>
+        Check for null renderer in canBeScrolledIntoView
+        https://bugs.webkit.org/show_bug.cgi?id=188935
+        Reviewed by Simon Fraser.
+        * fast/spatial-navigation/snav-display-contents-crash-expected.txt: Added.
+        * fast/spatial-navigation/snav-display-contents-crash.html: Added.
 -08-28  Youenn Fablet  <youenn@apple.com>

-              r236111
+              r236112
+-08-28  Don Olmstead  <don.olmstead@sony.com>
+        Check for null renderer in canBeScrolledIntoView
+        https://bugs.webkit.org/show_bug.cgi?id=188935
+        Reviewed by Simon Fraser.
+        Test: fast/spatial-navigation/snav-display-contents-crash.html
+        * page/SpatialNavigation.cpp:
+        (WebCore::canBeScrolledIntoView):
 -08-28  Youenn Fablet  <youenn@apple.com>

r232018	r236112
706	706	LayoutRect candidateRect = candidate.rect;
707	707	for (Node* parentNode = candidate.visibleNode->parentNode(); parentNode; parentNode = parentNode->parentNode()) {
	708	if (!parentNode->renderer())
	709	continue;
708	710	LayoutRect parentRect = nodeRectInAbsoluteCoordinates(parentNode);
709	711	if (!candidateRect.intersects(parentRect)) {

Note: See TracChangeset for help on using the changeset viewer.