Changeset 236231 in webkit

Timestamp:

Sep 19, 2018, 4:58:33 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

MediaStream-MediaElement-srcObject.https.html expects video duration for a MediaStream to be Infinity and is currently NaN
​https://bugs.webkit.org/show_bug.cgi?id=189516

Patch by YUHAN WU <​yuhan_wu@apple.com> on 2018-09-19
Reviewed by Youenn Fablet.

• web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html:
• web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt:

Location:

trunk/LayoutTests/imported/w3c

Files:

• ChangeLog (modified) (1 diff)
• web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt (modified) (1 diff)
• web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html (modified) (2 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2018-09-19  YUHAN WU  <yuhan_wu@apple.com>
+
+        MediaStream-MediaElement-srcObject.https.html expects video duration for a MediaStream to be Infinity and is currently NaN
+        https://bugs.webkit.org/show_bug.cgi?id=189516
+
+        Reviewed by Youenn Fablet.
+
+        * web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html:
+        * web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt:
+
 2018-09-19  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt

@@ -7 +7 @@
 
 
-FAIL Tests that a MediaStream can be assigned to a video element with srcObject assert_equals:  A MediaStream does not have a pre-defined duration.  expected Infinity but got NaN
+PASS Tests that a MediaStream can be assigned to a video element with srcObject 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html

@@ -27 +27 @@
          assert_equals(vid.played.length, 1, "A MediaStream's timeline always consists of a single range");
          assert_equals(vid.played.start(0), 0, "A MediaStream's timeline always consists of a single range");
-         assert_equals(vid.played.end(0), vid.currentTime, "A MediaStream's timeline always consists of a single range");
+         assert_approx_equals(vid.played.end(0), vid.currentTime, 0.0001, "A MediaStream's timeline always consists of a single range");
          assert_equals(vid.readyState, vid.HAVE_ENOUGH_DATA, "Upon selecting a media stream, the UA sets readyState to HAVE_ENOUGH_DATA");
+         assert_equals(vid.duration, Infinity, " A MediaStream does not have a pre-defined duration. ");
          var time = vid.currentTime;
-         assert_throws("INVALID_STATE_ERR", function() {
-            vid.currentTime = 0;
-         });
-         assert_equals(vid.currentTime, time, "The UA MUST ignore attempts to set the currentTime attribute");
+
+         assert_approx_equals(vid.currentTime, time, 0.0001, "The UA MUST ignore attempts to set the currentTime attribute");
          // TODO add test that duration must be set to currentTime
          // when mediastream is destroyed
@@ -47 +46 @@
       assert_equals(vid.playbackRate, 1, "playback rate is always 1");
       assert_equals(vid.buffered.length, 0, "A MediaStream cannot be preloaded.  Therefore, there is no buffered timeranges");
-      assert_equals(vid.duration, Infinity, " A MediaStream does not have a pre-defined duration. ");
-      assert_equals(vid.startDate, NaN, " A MediaStream does not specify a timeline offset");
+      assert_equals(vid.duration, vid.readyState == vid.HAVE_NOTHING ? NaN : Infinity, " A MediaStream does not have a pre-defined duration. ");
     }), function(error) {});
 });