Changeset 236232 in webkit

Timestamp:

Sep 19, 2018, 5:13:25 PM (8 years ago)

Author:

achristensen@apple.com

Message:

REGRESSION(236154) C API clients not using WKPageSetPageNavigationClient couldn't complete HTTPS requests
​https://bugs.webkit.org/show_bug.cgi?id=189771

Reviewed by Tim Horton.

• UIProcess/API/APINavigationClient.h:

(API::NavigationClient::didReceiveAuthenticationChallenge):
Perform default behavior if there's an authentication challenge but we're using the default navigation client.
I wish we had infrastructure to test this but WebKitTestRunner uses WKPageSetNavigationClient
and we don't have the ability to do networking from API tests. This is a growing problem I intend to solve.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/APINavigationClient.h (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-09-19  Alex Christensen  <achristensen@webkit.org>
+
+        REGRESSION(236154) C API clients not using WKPageSetPageNavigationClient couldn't complete HTTPS requests
+        https://bugs.webkit.org/show_bug.cgi?id=189771
+
+        Reviewed by Tim Horton.
+
+        * UIProcess/API/APINavigationClient.h:
+        (API::NavigationClient::didReceiveAuthenticationChallenge):
+        Perform default behavior if there's an authentication challenge but we're using the default navigation client.
+        I wish we had infrastructure to test this but WebKitTestRunner uses WKPageSetNavigationClient
+        and we don't have the ability to do networking from API tests.  This is a growing problem I intend to solve.
+
 2018-09-19  Woodrow Wang  <woodrow_wang@apple.com>
 

trunk/Source/WebKit/UIProcess/API/APINavigationClient.h

@@ -28 +28 @@
 #include "APIData.h"
 #include "APIString.h"
+#include "AuthenticationChallengeProxy.h"
+#include "AuthenticationDecisionListener.h"
 #include "PluginModuleInfo.h"
 #include "ProcessTerminationReason.h"
@@ -86 +88 @@
     virtual void renderingProgressDidChange(WebKit::WebPageProxy&, WebCore::LayoutMilestones) { }
 
-    virtual bool canAuthenticateAgainstProtectionSpace(WebKit::WebPageProxy&, WebKit::WebProtectionSpace*) { return false; }
-    virtual void didReceiveAuthenticationChallenge(WebKit::WebPageProxy&, WebKit::AuthenticationChallengeProxy&) { }
+    virtual void didReceiveAuthenticationChallenge(WebKit::WebPageProxy&, WebKit::AuthenticationChallengeProxy& challenge) { challenge.listener().performDefaultHandling(); }
 
     // FIXME: These function should not be part of this client.