Changeset 236245 in webkit

Timestamp:

Sep 20, 2018, 12:16:44 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Always prints in portrait when landscape is requested
​https://bugs.webkit.org/show_bug.cgi?id=189543

Patch by Tomas Popela <​tpopela@redhat.com> on 2018-09-20
Reviewed by Michael Catanzaro.

We have to change the surface size based on the requested orientation.
Otherwise only portrait will be printed as it's hardcoded.

• WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-09-20  Tomas Popela  <tpopela@redhat.com>
+
+        [GTK] Always prints in portrait when landscape is requested
+        https://bugs.webkit.org/show_bug.cgi?id=189543
+
+        Reviewed by Michael Catanzaro.
+
+        We have to change the surface size based on the requested orientation.
+        Otherwise only portrait will be printed as it's hardcoded.
+
+        * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
+
 2018-09-19  Dean Jackson  <dino@grorg.org>
 

trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp

@@ -135 +135 @@
             }
         } else if (surfaceType == CAIRO_SURFACE_TYPE_PDF)
-            cairo_pdf_surface_set_size(surface, width, height);
+            switch (gtk_page_setup_get_orientation(m_pageSetup.get())) {
+            case GTK_PAGE_ORIENTATION_PORTRAIT:
+            case GTK_PAGE_ORIENTATION_REVERSE_PORTRAIT:
+                cairo_pdf_surface_set_size(surface, width, height);
+                break;
+            case GTK_PAGE_ORIENTATION_LANDSCAPE:
+            case GTK_PAGE_ORIENTATION_REVERSE_LANDSCAPE:
+                cairo_pdf_surface_set_size(surface, height, width);
+                break;
+            }
     }