Changeset 236474 in webkit

Timestamp:

Sep 25, 2018, 2:06:31 PM (8 years ago)

Author:

achristensen@apple.com

Message:

Allow for suffixes to com.apple.WebKit.WebContent
​https://bugs.webkit.org/show_bug.cgi?id=189972

Reviewed by Chris Dumez.

Source/bmalloc:

• bmalloc/ProcessCheck.mm:

(bmalloc::gigacageEnabledForProcess):

Source/WebCore:

• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::isInWebProcess):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (modified) (1 diff)
• bmalloc/ChangeLog (modified) (1 diff)
• bmalloc/bmalloc/ProcessCheck.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-09-25  Alex Christensen  <achristensen@webkit.org>
+
+        Allow for suffixes to com.apple.WebKit.WebContent
+        https://bugs.webkit.org/show_bug.cgi?id=189972
+
+        Reviewed by Chris Dumez.
+
+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+        (WebCore::isInWebProcess):
+
 2018-09-25  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

@@ -87 +87 @@
 bool isInWebProcess()
 {
-    static bool mainBundleIsWebProcess = [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.WebKit.WebContent.Development"]
-        || [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.WebKit.WebContent"]
-        || [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.WebProcess"];
+    static bool mainBundleIsWebProcess = [[[NSBundle mainBundle] bundleIdentifier] hasPrefix:@"com.apple.WebKit.WebContent"];
     return mainBundleIsWebProcess;
 }

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2018-09-25  Alex Christensen  <achristensen@webkit.org>
+
+        Allow for suffixes to com.apple.WebKit.WebContent
+        https://bugs.webkit.org/show_bug.cgi?id=189972
+
+        Reviewed by Chris Dumez.
+
+        * bmalloc/ProcessCheck.mm:
+        (bmalloc::gigacageEnabledForProcess):
+
 2018-09-24  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/bmalloc/bmalloc/ProcessCheck.mm

@@ -39 +39 @@
     NSString *appName = [[NSBundle mainBundle] bundleIdentifier];
     if (appName) {
-        bool isWebProcess = [appName isEqualToString:@"com.apple.WebKit.WebContent.Development"]
-            || [appName isEqualToString:@"com.apple.WebKit.WebContent"]
-            || [appName isEqualToString:@"com.apple.WebProcess"];
+        bool isWebProcess = [appName hasPrefix:@"com.apple.WebKit.WebContent"];
         return isWebProcess;
     }