Changeset 236518 in webkit

Timestamp:

Sep 26, 2018, 12:47:46 PM (8 years ago)

Author:

rniwa@webkit.org

Message:

MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
​https://bugs.webkit.org/show_bug.cgi?id=189989

Reviewed by Simon Fraser.

When the preference isn't found in user defaults, use the default value of each feature's enabledness.

• MiniBrowser/mac/AppDelegate.m:

(defaultConfiguration):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/mac/AppDelegate.m (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
+
+        MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
+        https://bugs.webkit.org/show_bug.cgi?id=189989
+
+        Reviewed by Simon Fraser.
+
+        When the preference isn't found in user defaults, use the default value of each feature's enabledness.
+
+        * MiniBrowser/mac/AppDelegate.m:
+        (defaultConfiguration):
+
 2018-09-26  Philippe Normand  <pnormand@igalia.com>
 

trunk/Tools/MiniBrowser/mac/AppDelegate.m

@@ -110 +110 @@
         NSArray<_WKExperimentalFeature *> *experimentalFeatures = [WKPreferences _experimentalFeatures];
         for (_WKExperimentalFeature *feature in experimentalFeatures) {
-            BOOL enabled = [[NSUserDefaults standardUserDefaults] boolForKey:feature.key];
+            BOOL enabled;
+            if ([[NSUserDefaults standardUserDefaults] objectForKey:feature.key])
+                enabled = [[NSUserDefaults standardUserDefaults] boolForKey:feature.key];
+            else
+                enabled = [feature defaultValue];
             [configuration.preferences _setEnabled:enabled forExperimentalFeature:feature];
         }
@@ -116 +120 @@
         NSArray<_WKInternalDebugFeature *> *internalDebugFeatures = [WKPreferences _internalDebugFeatures];
         for (_WKInternalDebugFeature *feature in internalDebugFeatures) {
-            BOOL enabled = [[NSUserDefaults standardUserDefaults] boolForKey:feature.key];
+            BOOL enabled;
+            if ([[NSUserDefaults standardUserDefaults] objectForKey:feature.key])
+                enabled = [[NSUserDefaults standardUserDefaults] boolForKey:feature.key];
+            else
+                enabled = [feature defaultValue];
             [configuration.preferences _setEnabled:enabled forInternalDebugFeature:feature];
         }