Changeset 236945 in webkit

Timestamp:

Oct 8, 2018, 4:19:25 PM (8 years ago)

Author:

dino@apple.com

Message:

CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
​https://bugs.webkit.org/show_bug.cgi?id=190376
<rdar://problem/44986520>

Reviewed by Tim Horton.

Source/WebCore:

Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
depth from 256 to 128.

Modified existing test: compositing/layer-creation/deep-tree.html

• platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.

LayoutTests:

• compositing/layer-creation/deep-tree.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/layer-creation/deep-tree.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-10-08  Dean Jackson  <dino@apple.com>
+
+        CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+        https://bugs.webkit.org/show_bug.cgi?id=190376
+        <rdar://problem/44986520>
+
+        Reviewed by Tim Horton.
+
+        * compositing/layer-creation/deep-tree.html:
+
 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/LayoutTests/compositing/layer-creation/deep-tree.html

@@ -34 +34 @@
         function doTest()
         {
-            makeDeepTree(500, document.getElementById('deep'));
+            makeDeepTree(129, document.getElementById('deep'));
         }
         

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-10-08  Dean Jackson  <dino@apple.com>
+
+        CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+        https://bugs.webkit.org/show_bug.cgi?id=190376
+        <rdar://problem/44986520>
+
+        Reviewed by Tim Horton.
+
+        Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+        depth from 256 to 128.
+
+        Modified existing test: compositing/layer-creation/deep-tree.html
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+
 2018-10-08  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

@@ -90 +90 @@
 
 // Derived empirically: <rdar://problem/13401861>
-static const unsigned cMaxLayerTreeDepth = 250;
+static const unsigned cMaxLayerTreeDepth = 128;
 
 // About 10 screens of an iPhone 6 Plus. <rdar://problem/44532782>