Changeset 236958 in webkit

Timestamp:

Oct 8, 2018 8:28:31 PM (6 years ago)

Author:

Wenson Hsieh

Message:

[macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
​https://bugs.webkit.org/show_bug.cgi?id=190386

Reviewed by Ryosuke Niwa.

Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
of macOS.

• TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:

(TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
+        https://bugs.webkit.org/show_bug.cgi?id=190386
+
+        Reviewed by Ryosuke Niwa.
+
+        Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
+        Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
+        of macOS.
+
+        * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
+        (TEST):
+
 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm

@@ -79 +79 @@
     NSPasteboard *pasteboard = [NSPasteboard pasteboardWithUniqueName];
     [pasteboard declareTypes:@[NSColorPboardType] owner:nil];
-    [[NSColor redColor] writeToPasteboard:pasteboard];
+    [[NSColor colorWithRed:1 green:0 blue:0 alpha:1] writeToPasteboard:pasteboard];
 
     auto simulator = adoptNS([[DragAndDropSimulator alloc] initWithWebViewFrame:NSMakeRect(0, 0, 400, 400)]);