Changeset 236962 in webkit

Timestamp:

Oct 9, 2018, 8:31:31 AM (8 years ago)

Author:

mark.lam@apple.com

Message:

Revert temporary asserts for debugging a mysterious ASAN bot crash.
​https://bugs.webkit.org/show_bug.cgi?id=190396

Reviewed by Yusuke Suzuki.

• wtf/StackBounds.cpp:

(WTF::StackBounds::newThreadStackBounds):

• wtf/StackBounds.h:

(WTF::StackBounds::checkConsistency const):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/StackBounds.cpp (modified) (1 diff)
• wtf/StackBounds.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-10-09  Mark Lam  <mark.lam@apple.com>
+
+        Revert temporary asserts for debugging a mysterious ASAN bot crash.
+        https://bugs.webkit.org/show_bug.cgi?id=190396
+
+        Reviewed by Yusuke Suzuki.
+
+        * wtf/StackBounds.cpp:
+        (WTF::StackBounds::newThreadStackBounds):
+        * wtf/StackBounds.h:
+        (WTF::StackBounds::checkConsistency const):
+
 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/Source/WTF/wtf/StackBounds.cpp

@@ -145 +145 @@
     if (stackDirection() == StackDirection::Upward)
         std::swap(origin, bound);
-
-    // The following set of assertions are only needed for debugging a
-    // mysterious crash on an ASAN bot that is not reproducible otherwise.
-    // Will remove after the needed data has been collected.
-#if OS(LINUX)
-    else {
-        ASSERT(stackDirection() == StackDirection::Downward);
-        void* currentPosition = &currentPosition;
-        ASSERT_WITH_MESSAGE_UNUSED(currentPosition, (currentPosition < origin && currentPosition > bound), "newThreadStackBounds: currentPosition %p origin %p bound %p stackSize %zu", currentPosition, origin, bound, stackSize);
-    }
-#endif
-    // End of ASAN bot debugging assertions.
 
     return StackBounds { origin, bound };

trunk/Source/WTF/wtf/StackBounds.h

@@ -148 +148 @@
 #if !ASSERT_DISABLED
         void* currentPosition = &currentPosition;
-
-        // The following set of assertions are only needed for debugging a
-        // mysterious crash on an ASAN bot that is not reproducible otherwise.
-        // Will remove after the needed data has been collected.
-#if OS(LINUX)
-        if (isGrowingDownward())
-            ASSERT_WITH_MESSAGE((currentPosition < m_origin && currentPosition > m_bound), "checkConsistency: currentPosition %p m_origin %p m_bound %p stackSize %zu", currentPosition, m_origin, m_bound, (reinterpret_cast<uint8_t*>(m_origin) - reinterpret_cast<uint8_t*>(m_bound)));
-        else
-            ASSERT_WITH_MESSAGE((currentPosition > m_origin && currentPosition < m_bound), "checkConsistency: currentPosition %p m_origin %p m_bound %p stackSize %zu", currentPosition, m_origin, m_bound, (reinterpret_cast<uint8_t*>(m_bound) - reinterpret_cast<uint8_t*>(m_origin)));
-#endif // OS(LINUX)
-        // End of ASAN bot debugging assertions.
-
         ASSERT(m_origin != m_bound);
         ASSERT(isGrowingDownward()