Changeset 236967 in webkit

Timestamp:

Oct 9, 2018, 10:40:01 AM (8 years ago)

Author:

aboya@igalia.com

Message:

[MSE][GStreamer] r236735 has some dead ASSERTs that need to be moved
​https://bugs.webkit.org/show_bug.cgi?id=190394

Reviewed by Xabier Rodriguez-Calvar.

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::createOptionalParserForFormat):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/mse/AppendPipeline.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-10-09  Alicia Boya García  <aboya@igalia.com>
+
+        [MSE][GStreamer] r236735 has some dead ASSERTs that need to be moved
+        https://bugs.webkit.org/show_bug.cgi?id=190394
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+        (WebCore::createOptionalParserForFormat):
+
 2018-10-09  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp

@@ -860 +860 @@
     if (!g_strcmp0(mediaType, "audio/x-opus")) {
         GstElement* opusparse = gst_element_factory_make("opusparse", parserName.get());
+        ASSERT(opusparse);
         g_return_val_if_fail(opusparse, nullptr);
-        ASSERT(opusparse);
         return GRefPtr<GstElement>(opusparse);
     }
     if (!g_strcmp0(mediaType, "audio/x-vorbis")) {
         GstElement* vorbisparse = gst_element_factory_make("vorbisparse", parserName.get());
+        ASSERT(vorbisparse);
         g_return_val_if_fail(vorbisparse, nullptr);
-        ASSERT(vorbisparse);
         return GRefPtr<GstElement>(vorbisparse);
     }
     if (!g_strcmp0(mediaType, "video/x-h264")) {
         GstElement* h264parse = gst_element_factory_make("h264parse", parserName.get());
+        ASSERT(h264parse);
         g_return_val_if_fail(h264parse, nullptr);
-        ASSERT(h264parse);
         return GRefPtr<GstElement>(h264parse);
     }