Changeset 236977 in webkit

Timestamp:

Oct 9, 2018, 12:52:27 PM (8 years ago)

Author:

Alan Coon

Message:

Cherry-pick r236945. rdar://problem/45133492

CrashTracer: backboardd at Recursion

QuartzCore: CA::Render::Updater::prepare_sublayer0 ​https://bugs.webkit.org/show_bug.cgi?id=190376 <rdar://problem/44986520>

Reviewed by Tim Horton.

Source/WebCore:

Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
depth from 256 to 128.

Modified existing test: compositing/layer-creation/deep-tree.html

• platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.

LayoutTests:

• compositing/layer-creation/deep-tree.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@236945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-606.2.104.0-branch

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/layer-creation/deep-tree.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (modified) (1 diff)

branches/safari-606.2.104.0-branch/LayoutTests/ChangeLog

@@ +1 @@
+2018-10-09  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r236945. rdar://problem/45133492
+
+    CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+    https://bugs.webkit.org/show_bug.cgi?id=190376
+    <rdar://problem/44986520>
+    
+    Reviewed by Tim Horton.
+    
+    Source/WebCore:
+    
+    Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+    depth from 256 to 128.
+    
+    Modified existing test: compositing/layer-creation/deep-tree.html
+    
+    * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+    
+    LayoutTests:
+    
+    * compositing/layer-creation/deep-tree.html:
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-10-08  Dean Jackson  <dino@apple.com>
+
+            CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+            https://bugs.webkit.org/show_bug.cgi?id=190376
+            <rdar://problem/44986520>
+
+            Reviewed by Tim Horton.
+
+            * compositing/layer-creation/deep-tree.html:
+
 2018-09-28  Babak Shafiei  <bshafiei@apple.com>
 

branches/safari-606.2.104.0-branch/LayoutTests/compositing/layer-creation/deep-tree.html

@@ -34 +34 @@
         function doTest()
         {
-            makeDeepTree(500, document.getElementById('deep'));
+            makeDeepTree(129, document.getElementById('deep'));
         }
         

branches/safari-606.2.104.0-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2018-10-09  Kocsen Chung  <kocsen_chung@apple.com>
+
+        Cherry-pick r236945. rdar://problem/45133492
+
+    CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+    https://bugs.webkit.org/show_bug.cgi?id=190376
+    <rdar://problem/44986520>
+    
+    Reviewed by Tim Horton.
+    
+    Source/WebCore:
+    
+    Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+    depth from 256 to 128.
+    
+    Modified existing test: compositing/layer-creation/deep-tree.html
+    
+    * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+    
+    LayoutTests:
+    
+    * compositing/layer-creation/deep-tree.html:
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-10-08  Dean Jackson  <dino@apple.com>
+
+            CrashTracer: backboardd at Recursion :: QuartzCore: CA::Render::Updater::prepare_sublayer0
+            https://bugs.webkit.org/show_bug.cgi?id=190376
+            <rdar://problem/44986520>
+
+            Reviewed by Tim Horton.
+
+            Very deep CoreAnimation layer trees can cause problems. Reduce our maximum
+            depth from 256 to 128.
+
+            Modified existing test: compositing/layer-creation/deep-tree.html
+
+            * platform/graphics/ca/GraphicsLayerCA.cpp: Cap the depth at 128.
+
 2018-10-03  Kocsen Chung  <kocsen_chung@apple.com>
 

branches/safari-606.2.104.0-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

@@ -90 +90 @@
 
 // Derived empirically: <rdar://problem/13401861>
-static const unsigned cMaxLayerTreeDepth = 250;
+static const unsigned cMaxLayerTreeDepth = 128;
 
 // About 10 screens of an iPhone 6 Plus. <rdar://problem/44532782>