⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 236990 in webkit


Ignore:
Timestamp:
Oct 9, 2018, 4:46:12 PM (8 years ago)
Author:
jer.noble@apple.com
Message:

Crash when closing WKWebView during enter fullscreen animation
​https://bugs.webkit.org/show_bug.cgi?id=190412

Reviewed by Brian Burg.

Source/WebKit:

We need a valid _webView if, during -[NSWindow close], we catch a notification saying we failed to enter
fullscreen and try to replace the placeholder with the actual _webView.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController close]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.

(-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
(-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
(TestWebKitAPI::TEST):

Location:
trunk
Files:
1 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r236989 r236990  
     12018-10-09  Jer Noble  <jer.noble@apple.com>
     2
     3        Crash when closing WKWebView during enter fullscreen animation
     4        https://bugs.webkit.org/show_bug.cgi?id=190412
     5
     6        Reviewed by Brian Burg.
     7
     8        We need a valid _webView if, during -[NSWindow close], we catch a notification saying we failed to enter
     9        fullscreen and try to replace the placeholder with the actual _webView.
     10
     11        * UIProcess/mac/WKFullScreenWindowController.mm:
     12        (-[WKFullScreenWindowController close]):
     13
    1142018-10-09  Alex Christensen  <achristensen@webkit.org>
    215

  • trunk/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm

    r236748 r236990  
    530530        [self finishedExitFullScreenAnimation:YES];
    531531
     532    [super close];
     533
    532534    _webView = nil;
    533 
    534     [super close];
    535535}
    536536

  • trunk/Tools/ChangeLog

    r236987 r236990  
     12018-10-09  Jer Noble  <jer.noble@apple.com>
     2
     3        Crash when closing WKWebView during enter fullscreen animation
     4        https://bugs.webkit.org/show_bug.cgi?id=190412
     5
     6        Reviewed by Brian Burg.
     7
     8        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
     9        * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
     10        (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
     11        (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
     12        (TestWebKitAPI::TEST):
     13
    1142018-10-09  Chris Dumez  <cdumez@apple.com>
    215

  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r236984 r236990  
    754754                CDCFA7AA1E45183200C2433D /* SampleMap.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDCFA7A91E45122F00C2433D /* SampleMap.cpp */; };
    755755                CDE195B51CFE0B880053D256 /* FullscreenTopContentInset.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CDE195B21CFE0ADE0053D256 /* FullscreenTopContentInset.html */; };
     756                CDF0B78A216D48DC00421ECC /* CloseWebViewDuringEnterFullscreen.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDF0B789216D484300421ECC /* CloseWebViewDuringEnterFullscreen.mm */; };
    756757                CDF92237216D186400647AA7 /* CloseWebViewAfterEnterFullscreen.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDF92236216D186400647AA7 /* CloseWebViewAfterEnterFullscreen.mm */; };
    757758                CE06DF9B1E1851F200E570C9 /* SecurityOrigin.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CE06DF9A1E1851F200E570C9 /* SecurityOrigin.cpp */; };
    … …  
    19951996                CDE195B21CFE0ADE0053D256 /* FullscreenTopContentInset.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = FullscreenTopContentInset.html; sourceTree = "<group>"; };
    19961997                CDE195B31CFE0ADE0053D256 /* FullscreenTopContentInset.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = FullscreenTopContentInset.mm; sourceTree = "<group>"; };
     1998                CDF0B789216D484300421ECC /* CloseWebViewDuringEnterFullscreen.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = CloseWebViewDuringEnterFullscreen.mm; sourceTree = "<group>"; };
    19971999                CDF92236216D186400647AA7 /* CloseWebViewAfterEnterFullscreen.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = CloseWebViewAfterEnterFullscreen.mm; sourceTree = "<group>"; };
    19982000                CE06DF9A1E1851F200E570C9 /* SecurityOrigin.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SecurityOrigin.cpp; sourceTree = "<group>"; };
    … …  
    23322334                                5CB18BA71F5645B200EE23C4 /* ClickAutoFillButton.mm */,
    23332335                                CDF92236216D186400647AA7 /* CloseWebViewAfterEnterFullscreen.mm */,
     2336                                CDF0B789216D484300421ECC /* CloseWebViewDuringEnterFullscreen.mm */,
    23342337                                1AAD19F51C7CE20300831E47 /* Coding.mm */,
    23352338                                7C3DB8E21D12129B00AE8CC3 /* CommandBackForward.mm */,
    … …  
    37413744                                7CCE7EB71A411A7E00447C4C /* CloseNewWindowInNavigationPolicyDelegate.mm in Sources */,
    37423745                                7CCE7EE51A411AE600447C4C /* CloseThenTerminate.cpp in Sources */,
     3746                                CDF92237216D186400647AA7 /* CloseWebViewAfterEnterFullscreen.mm in Sources */,
     3747                                CDF0B78A216D48DC00421ECC /* CloseWebViewDuringEnterFullscreen.mm in Sources */,
    37433748                                7C83E0BA1D0A64FB00FEBCF3 /* Coding.mm in Sources */,
    37443749                                7C3965061CDD74F90094DBB8 /* Color.cpp in Sources */,
    … …  
    39123917                                7C83E0B71D0A64B800FEBCF3 /* MenuTypesForMouseEvents.cpp in Sources */,
    39133918                                5C0BF8941DD599C900B00328 /* MenuTypesForMouseEvents.mm in Sources */,
    3914                                 CDF92237216D186400647AA7 /* CloseWebViewAfterEnterFullscreen.mm in Sources */,
    39153919                                5165FE04201EE620009F7EC3 /* MessagePortProviders.mm in Sources */,
    39163920                                A5B149DE1F5A19EA00C6DAFF /* MIMETypeRegistry.cpp in Sources */,
Note: See TracChangeset for help on using the changeset viewer.