Changeset 236994 in webkit

Timestamp:

Oct 9, 2018, 5:31:33 PM (8 years ago)

Author:

youenn@apple.com

Message:

ASSERTION FAILED: m_cachesLocks.contains(sessionID) in WebKit::CacheStorageEngineConnection::dereference(PAL::SessionID, unsigned long long)
​https://bugs.webkit.org/show_bug.cgi?id=190373
<rdar://problem/45106402>

Reviewed by Alex Christensen.

This assertion can be hit if:

• WebProcess has a DOMCache
• NetworkProcess crashes
• WebProcess navigates and dereference DOMCache.

Remove this assertion as it is hit when a test is using testRunner.terminateNetworkProcess().

• NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::dereference):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cache/CacheStorageEngineConnection.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-10-09  Youenn Fablet  <youenn@apple.com>
+
+        ASSERTION FAILED: m_cachesLocks.contains(sessionID) in WebKit::CacheStorageEngineConnection::dereference(PAL::SessionID, unsigned long long)
+        https://bugs.webkit.org/show_bug.cgi?id=190373
+        <rdar://problem/45106402>
+
+        Reviewed by Alex Christensen.
+
+        This assertion can be hit if:
+        - WebProcess has a DOMCache
+        - NetworkProcess crashes
+        - WebProcess navigates and dereference DOMCache.
+        Remove this assertion as it is hit when a test is using testRunner.terminateNetworkProcess().
+
+        * NetworkProcess/cache/CacheStorageEngineConnection.cpp:
+        (WebKit::CacheStorageEngineConnection::dereference):
+
 2018-10-09  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineConnection.cpp

@@ -133 +133 @@
 {
     RELEASE_LOG_IF_ALLOWED("dereference cache %" PRIu64, cacheIdentifier);
-    ASSERT(m_cachesLocks.contains(sessionID));
     auto& references = m_cachesLocks.ensure(sessionID, []() {
         return HashMap<CacheIdentifier, LockCount> { };