Changeset 237448 in webkit

Timestamp:

Oct 26, 2018, 1:25:43 AM (8 years ago)

Author:

keith_miller@apple.com

Message:

Some internal projects include wtf headers and build with C++11
​https://bugs.webkit.org/show_bug.cgi?id=190791

Reviewed by Alexey Proskuryakov.

C++11 doesn't support constexpr functions that contain
statements. This patch removes getLSBSet set from builds before
C++14 to avoid this for now.

• wtf/MathExtras.h:

(getLSBSet):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/MathExtras.h (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-10-26  Keith Miller  <keith_miller@apple.com>
+
+        Some internal projects include wtf headers and build with C++11
+        https://bugs.webkit.org/show_bug.cgi?id=190791
+
+        Reviewed by Alexey Proskuryakov.
+
+        C++11 doesn't support constexpr functions that contain
+        statements. This patch removes getLSBSet set from builds before
+        C++14 to avoid this for now.
+
+        * wtf/MathExtras.h:
+        (getLSBSet):
+
 2018-10-25  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/WTF/wtf/MathExtras.h

@@ -207 +207 @@
 }
 
+// FIXME: Some Darwin projects shamelessly include WTF headers and don't build with C++14... See: rdar://problem/45395767
+// Since C++11 and before don't support constexpr statements we can't mark this function constexpr.
+#if !defined(WTF_CPP_STD_VER) || WTF_CPP_STD_VER >= 14
 template <typename T> constexpr unsigned getLSBSet(T value)
 {
@@ -218 +221 @@
     return result;
 }
+#endif
 
 template<typename T> inline T divideRoundedUp(T a, T b)