Changeset 237449 in webkit

Timestamp:

Oct 26, 2018, 6:16:03 AM (8 years ago)

Author:

ajuma@chromium.org

Message:

REGRESSION (r237255): Text selection is broken in form fields
​https://bugs.webkit.org/show_bug.cgi?id=190899

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix missing negation when checking for a fully-clipped-out rect. This was causing
RenderObject::computeVisibleRectInContainer to incorrectly early-out.

Test: fast/repaint/text-selection-overflow-hidden.html

• rendering/RenderObject.cpp:

(WebCore::RenderObject::computeVisibleRectInContainer const):

LayoutTests:

Add layout test coverage.

• fast/repaint/text-selection-overflow-hidden-expected.txt: Added.
• fast/repaint/text-selection-overflow-hidden.html: Added.
• platform/win/fast/repaint/text-selection-overflow-hidden-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/text-selection-overflow-hidden-expected.txt (added)
• LayoutTests/fast/repaint/text-selection-overflow-hidden.html (added)
• LayoutTests/platform/win/fast/repaint/text-selection-overflow-hidden-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-10-26  Ali Juma  <ajuma@chromium.org>
+
+        REGRESSION (r237255): Text selection is broken in form fields
+        https://bugs.webkit.org/show_bug.cgi?id=190899
+
+        Reviewed by Ryosuke Niwa.
+
+        Add layout test coverage.
+
+        * fast/repaint/text-selection-overflow-hidden-expected.txt: Added.
+        * fast/repaint/text-selection-overflow-hidden.html: Added.
+        * platform/win/fast/repaint/text-selection-overflow-hidden-expected.txt: Added.
+
 2018-10-25  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-10-26  Ali Juma  <ajuma@chromium.org>
+
+        REGRESSION (r237255): Text selection is broken in form fields
+        https://bugs.webkit.org/show_bug.cgi?id=190899
+
+        Reviewed by Ryosuke Niwa.
+
+        Fix missing negation when checking for a fully-clipped-out rect. This was causing
+        RenderObject::computeVisibleRectInContainer to incorrectly early-out.
+
+        Test: fast/repaint/text-selection-overflow-hidden.html
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::computeVisibleRectInContainer const):
+
 2018-10-25  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/rendering/RenderObject.cpp

@@ -1001 +1001 @@
     LayoutRect adjustedRect = rect;
     if (parent->hasOverflowClip()) {
-        bool isEmpty = downcast<RenderBox>(*parent).applyCachedClipAndScrollPosition(adjustedRect, container, context);
+        bool isEmpty = !downcast<RenderBox>(*parent).applyCachedClipAndScrollPosition(adjustedRect, container, context);
         if (isEmpty) {
             if (context.m_options.contains(VisibleRectContextOption::UseEdgeInclusiveIntersection))