Changeset 237481 in webkit

Timestamp:

Oct 26, 2018, 1:43:04 PM (8 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'this._classListContainer.children')
​https://bugs.webkit.org/show_bug.cgi?id=190966

Reviewed by Joseph Pecoraro.

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:

(WI.GeneralStyleDetailsSidebarPanel.prototype.layout):
(WI.GeneralStyleDetailsSidebarPanel.prototype._classToggleButtonClicked):
(WI.GeneralStyleDetailsSidebarPanel.prototype._populateClassToggles):
Don't try to reload the class toggles if the we haven't layout yet, as the element won't
yet exist.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/GeneralStyleDetailsSidebarPanel.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-10-26  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'this._classListContainer.children')
+        https://bugs.webkit.org/show_bug.cgi?id=190966
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
+        (WI.GeneralStyleDetailsSidebarPanel.prototype.layout):
+        (WI.GeneralStyleDetailsSidebarPanel.prototype._classToggleButtonClicked):
+        (WI.GeneralStyleDetailsSidebarPanel.prototype._populateClassToggles):
+        Don't try to reload the class toggles if the we haven't `layout` yet, as the element won't
+        yet exist.
+
 2018-10-25  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js

@@ -105 +105 @@
 
         this._updatePseudoClassCheckboxes();
-
-        if (!this._classListContainer.hidden)
-            this._populateClassToggles();
+        this._populateClassToggles();
     }
 
@@ -325 +323 @@
         this._classListContainer.hidden = !this._classListContainer.hidden;
         this._classListContainerToggledSetting.value = !this._classListContainer.hidden;
-        if (this._classListContainer.hidden)
-            return;
-
         this._populateClassToggles();
     }
@@ -354 +349 @@
     _populateClassToggles()
     {
+        if (!this._classListContainer || this._classListContainer.hidden)
+            return;
+
         // Ensure that _addClassContainer is the first child of _classListContainer.
         while (this._classListContainer.children.length > 1)