Changeset 237645 in webkit

Timestamp:

Oct 31, 2018, 11:44:11 AM (8 years ago)

Author:

Tadeu Zagallo

Message:

Adjust inlining threshold for new bytecode format
​https://bugs.webkit.org/show_bug.cgi?id=191115

Reviewed by Saam Barati.

The new format reduced the number of operands for many opcodes, which
changed inlining decisions and impacted performance negatively.

• runtime/Options.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/Options.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-10-31  Tadeu Zagallo  <tzagallo@apple.com>
+
+        Adjust inlining threshold for new bytecode format
+        https://bugs.webkit.org/show_bug.cgi?id=191115
+
+        Reviewed by Saam Barati.
+
+        The new format reduced the number of operands for many opcodes, which
+        changed inlining decisions and impacted performance negatively.
+
+        * runtime/Options.h:
+
 2018-10-31  Tadeu Zagallo  <tzagallo@apple.com>
 

trunk/Source/JavaScriptCore/runtime/Options.h

@@ -304 +304 @@
     v(unsigned, maximumOptimizationCandidateInstructionCount, 100000, Normal, nullptr) \
     \
-    v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 190, Normal, nullptr) \
+    v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 120, Normal, nullptr) \
     v(unsigned, maximumFunctionForClosureCallInlineCandidateInstructionCount, 100, Normal, nullptr) \
     v(unsigned, maximumFunctionForConstructInlineCandidateInstructionCount, 100, Normal, nullptr) \