Changeset 238236 in webkit

Timestamp:

Nov 15, 2018, 11:43:59 AM (8 years ago)

Author:

Michael Catanzaro

Message:

[SOUP] Make Accept-Languages header look more like other browsers
​https://bugs.webkit.org/show_bug.cgi?id=191614

Reviewed by Carlos Garcia Campos.

This changes our Accept-Language header to better match other browsers, from something
like this:

Accept-Language: en-us, en;q=0.90, es-es;q=0.80, es;q=0.70

to something like this:

Accept-Language: en-US,en;q=0.90,es-ES;q=0.80,es;q=0.70

There's no particular motivation for this change. I just noticed we were different for no
clear reason.

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::buildAcceptLanguages):

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_preferred_languages):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/soup/NetworkProcessSoup.cpp (modified) (1 diff)
• UIProcess/API/glib/WebKitWebContext.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-15  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [SOUP] Make Accept-Languages header look more like other browsers
+        https://bugs.webkit.org/show_bug.cgi?id=191614
+
+        Reviewed by Carlos Garcia Campos.
+
+        This changes our Accept-Language header to better match other browsers, from something
+        like this:
+
+        Accept-Language: en-us, en;q=0.90, es-es;q=0.80, es;q=0.70
+
+        to something like this:
+
+        Accept-Language: en-US,en;q=0.90,es-ES;q=0.80,es;q=0.70
+
+        There's no particular motivation for this change. I just noticed we were different for no
+        clear reason.
+
+        * NetworkProcess/soup/NetworkProcessSoup.cpp:
+        (WebKit::buildAcceptLanguages):
+        * UIProcess/API/glib/WebKitWebContext.cpp:
+        (webkit_web_context_set_preferred_languages):
+
 2018-11-15  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp

@@ -77 +77 @@
 
         if (i)
-            builder.appendLiteral(", ");
+            builder.appendLiteral(",");
 
         builder.append(languages[i]);

trunk/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp

@@ -1313 +1313 @@
         // Do not propagate the C locale to WebCore.
         if (!g_ascii_strcasecmp(languageList[i], "C") || !g_ascii_strcasecmp(languageList[i], "POSIX"))
-            languages.append("en-us"_s);
+            languages.append("en-US"_s);
         else
-            languages.append(String::fromUTF8(languageList[i]).convertToASCIILowercase().replace("_", "-"));
+            languages.append(String::fromUTF8(languageList[i]).replace("_", "-"));
     }
     overrideUserPreferredLanguages(languages);