Changeset 238254 in webkit

Timestamp:

Nov 15, 2018 2:42:56 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Remove unused WebInspectorProxy code
​https://bugs.webkit.org/show_bug.cgi?id=191674

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-15
Reviewed by Dean Jackson.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::closeFrontendPageAndWindow):

• UIProcess/WebInspectorProxy.h:
• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::setInspectorWindowFrame): Deleted.
(WebKit::WebInspectorProxy::inspectorWindowFrame): Deleted.

• WebProcess/WebPage/WebInspector.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebInspectorProxy.cpp (modified) (2 diffs)
• UIProcess/WebInspectorProxy.h (modified) (2 diffs)
• UIProcess/mac/WebInspectorProxyMac.mm (modified) (1 diff)
• WebProcess/WebPage/WebInspector.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-15  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Remove unused WebInspectorProxy code
+        https://bugs.webkit.org/show_bug.cgi?id=191674
+
+        Reviewed by Dean Jackson.
+
+        * UIProcess/WebInspectorProxy.cpp:
+        (WebKit::WebInspectorProxy::createInspectorPage):
+        (WebKit::WebInspectorProxy::closeFrontendPageAndWindow):
+        * UIProcess/WebInspectorProxy.h:
+        * UIProcess/mac/WebInspectorProxyMac.mm:
+        (WebKit::WebInspectorProxy::setInspectorWindowFrame): Deleted.
+        (WebKit::WebInspectorProxy::inspectorWindowFrame): Deleted.
+        * WebProcess/WebPage/WebInspector.h:
+
 2018-11-15  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp

@@ -354 +354 @@
         return;
 
-    m_connectionIdentifier = WTFMove(connectionIdentifier);
-
-    m_inspectorPage->process().send(Messages::WebInspectorUI::EstablishConnection(m_connectionIdentifier, m_inspectedPage->pageID(), m_underTest, inspectionLevel()), m_inspectorPage->pageID());
+    m_inspectorPage->process().send(Messages::WebInspectorUI::EstablishConnection(WTFMove(connectionIdentifier), m_inspectedPage->pageID(), m_underTest, inspectionLevel()), m_inspectorPage->pageID());
 
     if (!m_underTest) {
@@ -438 +436 @@
     m_underTest = false;
 
-    m_connectionIdentifier = IPC::Attachment();
-
     platformCloseFrontendPageAndWindow();
 }

trunk/Source/WebKit/UIProcess/WebInspectorProxy.h

@@ -108 +108 @@
     NSWindow* inspectorWindow() const { return m_inspectorWindow.get(); }
 
-    void setInspectorWindowFrame(WKRect&);
-    WKRect inspectorWindowFrame();
-
     void closeFrontendPage();
     void closeFrontendAfterInactivityTimerFired();
@@ -243 +240 @@
     bool m_ignoreElementSelectionChange { false };
     bool m_isOpening { false };
-
-    IPC::Attachment m_connectionIdentifier;
 
     AttachmentSide m_attachmentSide {AttachmentSide::Bottom};

trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm

@@ -211 +211 @@
 }
 
-void WebInspectorProxy::setInspectorWindowFrame(WKRect& frame)
-{
-    if (m_isAttached)
-        return;
-
-    [m_inspectorWindow setFrame:NSMakeRect(frame.origin.x, frame.origin.y, frame.size.width, frame.size.height) display:YES];
-}
-
-WKRect WebInspectorProxy::inspectorWindowFrame()
-{
-    if (m_isAttached)
-        return WKRectMake(0, 0, 0, 0);
-
-    NSRect frame = m_inspectorWindow.get().frame;
-    return WKRectMake(frame.origin.x, frame.origin.y, frame.size.width, frame.size.height);
-}
-
 void WebInspectorProxy::updateInspectorWindowTitle() const
 {

trunk/Source/WebKit/WebProcess/WebPage/WebInspector.h

@@ -55 +55 @@
     void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference) override { close(); }
 
-    // Called by WebInspector messages
-    void connectionEstablished();
-
     void show();
     void close();