Changeset 238280 in webkit

Timestamp:

Nov 16, 2018, 7:07:17 AM (8 years ago)

Author:

Alan Bujtas

Message:

Source/WebCore:
[iOS] 2 subsequent taps are required to trigger certain tasks on the desktop version of YouTube.com (hover vs click).
​https://bugs.webkit.org/show_bug.cgi?id=191712
<rdar://problem/45612900>

Reviewed by Simon Fraser.

In handleSyntheticClick() we use WKContentObservation to figure out whether the tap should be treated as a hover or a click.
In general, if the mouse-move event triggers a visible content change, we assume we hit a hover-like drop down menu (or something similar)
and no need to dispatch a click event.
The idea here is that if the new content (result of the mouse-move event) does not respond to mouse click, it is most likely
only for tooltip-like reasons and it's ok to proceed with the click event.

Test: fast/events/touch/ios/click-instead-of-hover-simple.html

• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::CheckForVisibilityChange::~CheckForVisibilityChange):

LayoutTests:
[iOS] 2 subsequent taps are required to trigger certain tasks on the desktop version of YouTube.com
​https://bugs.webkit.org/show_bug.cgi?id=191712
<rdar://problem/45612900>

Reviewed by Simon Fraser.

• fast/events/touch/ios/click-instead-of-hover-simple-expected.txt: Added.
• fast/events/touch/ios/click-instead-of-hover-simple.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/touch/ios/click-instead-of-hover-simple-expected.txt (added)
• LayoutTests/fast/events/touch/ios/click-instead-of-hover-simple.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/updating/RenderTreeUpdater.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-11-16  Zalan Bujtas  <zalan@apple.com>
+
+        [iOS] 2 subsequent taps are required to trigger certain tasks on the desktop version of YouTube.com
+        https://bugs.webkit.org/show_bug.cgi?id=191712
+        <rdar://problem/45612900>
+
+        Reviewed by Simon Fraser.
+
+        * fast/events/touch/ios/click-instead-of-hover-simple-expected.txt: Added.
+        * fast/events/touch/ios/click-instead-of-hover-simple.html: Added.
+
 2018-11-16  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-11-16  Zalan Bujtas  <zalan@apple.com>
+
+        [iOS] 2 subsequent taps are required to trigger certain tasks on the desktop version of YouTube.com (hover vs click).
+        https://bugs.webkit.org/show_bug.cgi?id=191712
+        <rdar://problem/45612900>
+
+        Reviewed by Simon Fraser.
+
+        In handleSyntheticClick() we use WKContentObservation to figure out whether the tap should be treated as a hover or a click.
+        In general, if the mouse-move event triggers a visible content change, we assume we hit a hover-like drop down menu (or something similar)
+        and no need to dispatch a click event.
+        The idea here is that if the new content (result of the mouse-move event) does not respond to mouse click, it is most likely
+        only for tooltip-like reasons and it's ok to proceed with the click event.
+
+        Test: fast/events/touch/ios/click-instead-of-hover-simple.html
+
+        * rendering/updating/RenderTreeUpdater.cpp:
+        (WebCore::CheckForVisibilityChange::~CheckForVisibilityChange):
+
 2018-11-16  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

@@ -680 +680 @@
     if (!WKObservingContentChanges())
         return;
-    if (m_element.isInUserAgentShadowTree())
-        return;
+
     auto* style = m_element.renderStyle();
-    if (!style)
+
+    auto qualifiesForVisibilityCheck = [&] {
+        if (!style)
+            return false;
+        if (m_element.isInUserAgentShadowTree())
+            return false;
+        if (!const_cast<Element&>(m_element).willRespondToMouseClickEvents())
+            return false;
+        return true;
+    };
+
+    if (!qualifiesForVisibilityCheck())
         return;
     if ((m_previousDisplay == DisplayType::None && style->display() != DisplayType::None) || (m_previousVisibility == Visibility::Hidden && style->visibility() != Visibility::Hidden)