Changeset 238323 in webkit

Timestamp:

Nov 16, 2018 4:17:32 PM (6 years ago)

Author:

Chris Dumez

Message:

Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
​https://bugs.webkit.org/show_bug.cgi?id=191789

Reviewed by Alex Christensen.

Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
SPI no longer works with PSON / Process prewarming.

• TestWebKitAPI/Tests/WebKit/Geolocation.cpp:

(TestWebKitAPI::TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKit/Geolocation.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-11-16  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=191789
+
+        Reviewed by Alex Christensen.
+
+        Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
+        SPI no longer works with PSON / Process prewarming.
+
+        * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
+        (TestWebKitAPI::TEST):
+
 2018-11-16  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit/Geolocation.cpp

@@ -258 +258 @@
 {
     WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());
-    WKContextSetMaximumNumberOfProcesses(context.get(), 1);
 
     GeolocationTransitionToHighAccuracyStateTracker stateTracker;
@@ -269 +268 @@
     Util::run(&stateTracker.finishedFirstStep);
 
-    PlatformWebView highAccuracyWebView(context.get());
+    PlatformWebView highAccuracyWebView(lowAccuracyWebView.page());
     setupView(highAccuracyWebView);
     WKRetainPtr<WKURLRef> highAccuracyURL(AdoptWK, Util::createURLForResource("geolocationWatchPositionWithHighAccuracy", "html"));