Changeset 238429 in webkit

Timestamp:

Nov 21, 2018, 1:33:48 PM (8 years ago)

Author:

rniwa@webkit.org

Message:

Mutation observers doesn't get notified of character data mutation made by the parser
​https://bugs.webkit.org/show_bug.cgi?id=191874

Reviewed by Antti Koivisto.

Source/WebCore:

Fixed the bug that CharacterData::parserAppendData was never notifying MutationObserver.

Test: fast/dom/MutationObserver/observe-parser-character-data-change.html

• dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):

LayoutTests:

Added a regression test.

• fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt: Added.
• fast/dom/MutationObserver/observe-parser-character-data-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt (added)
• LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/CharacterData.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-11-21  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Mutation observers doesn't get notified of character data mutation made by the parser
+        https://bugs.webkit.org/show_bug.cgi?id=191874
+
+        Reviewed by Antti Koivisto.
+
+        Added a regression test.
+
+        * fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt: Added.
+        * fast/dom/MutationObserver/observe-parser-character-data-change.html: Added.
+
 2018-11-21  Zalan Bujtas <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-11-20  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Mutation observers doesn't get notified of character data mutation made by the parser
+        https://bugs.webkit.org/show_bug.cgi?id=191874
+
+        Reviewed by Antti Koivisto.
+
+        Fixed the bug that CharacterData::parserAppendData was never notifying MutationObserver.
+
+        Test: fast/dom/MutationObserver/observe-parser-character-data-change.html
+
+        * dom/CharacterData.cpp:
+        (WebCore::CharacterData::parserAppendData):
+
 2018-11-21  Claudio Saavedra  <csaavedra@igalia.com>
 

trunk/Source/WebCore/dom/CharacterData.cpp

@@ -97 +97 @@
         return 0;
 
+    String oldData = m_data;
     if (string.is8Bit())
         m_data.append(string.characters8() + offset, characterLengthLimit);
@@ -107 +108 @@
 
     notifyParentAfterChange(ContainerNode::ChildChangeSource::Parser);
+
+    auto mutationRecipients = MutationObserverInterestGroup::createForCharacterDataMutation(*this);
+    if (UNLIKELY(mutationRecipients))
+        mutationRecipients->enqueueMutationRecord(MutationRecord::createCharacterData(*this, oldData));
 
     return characterLengthLimit;