Changeset 238444 in webkit

Timestamp:

Nov 22, 2018, 4:53:39 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[Flatpak] Do not disable signals when running "usual" commands
​https://bugs.webkit.org/show_bug.cgi?id=190679

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-22
Reviewed by Philippe Normand.

Otherwise <ctr>c doesn't work while compiling. It is not the best fix
as there are cases we want to let only children receive signals, but
it is not clear how to determine when (when running gdb, we still
disable those).

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• flatpak/flatpakutils.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-11-22  Thibault Saunier  <tsaunier@igalia.com>
+
+        [Flatpak] Do not disable signals when running "usual" commands
+        https://bugs.webkit.org/show_bug.cgi?id=190679
+
+        Reviewed by Philippe Normand.
+
+        Otherwise <ctr>c doesn't work while compiling. It is not the best fix
+        as there are cases we want to let only children receive signals, but
+        it is not clear how to determine when (when running gdb, we still
+        disable those).
+
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.run_in_sandbox):
+
 2018-11-21  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/flatpak/flatpakutils.py

@@ -747 +747 @@
             flatpak_command.extend(['sh', "/run/host/" + tmpscript.name])
 
-            with disable_signals():
-                try:
-                    subprocess.check_call(flatpak_command, stdout=stdout)
-                except subprocess.CalledProcessError as e:
-                    sys.stderr.write(str(e) + "\n")
-                    return e.returncode
+            try:
+                subprocess.check_call(flatpak_command, stdout=stdout)
+            except subprocess.CalledProcessError as e:
+                sys.stderr.write(str(e) + "\n")
+                return e.returncode
 
         return 0