Changeset 238455 in webkit

Timestamp:

Nov 22, 2018 8:00:31 PM (5 years ago)

Author:

Wenson Hsieh

Message:

[Cocoa] clang emits a warning when building WebKit after r238293
​https://bugs.webkit.org/show_bug.cgi?id=191917

Reviewed by Dan Bernstein.

Move the implementations of -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled to the main implementation of
WKPreferences to fix the warning.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences setSafeBrowsingEnabled:]):
(-[WKPreferences isSafeBrowsingEnabled]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKPreferences.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [Cocoa] clang emits a warning when building WebKit after r238293
+        https://bugs.webkit.org/show_bug.cgi?id=191917
+
+        Reviewed by Dan Bernstein.
+
+        Move the implementations of -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled to the main implementation of
+        WKPreferences to fix the warning.
+
+        * UIProcess/API/Cocoa/WKPreferences.mm:
+        (-[WKPreferences setSafeBrowsingEnabled:]):
+        (-[WKPreferences isSafeBrowsingEnabled]):
+
 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm

@@ -141 +141 @@
 }
 
+- (void)setSafeBrowsingEnabled:(BOOL)enabled
+{
+    _preferences->setSafeBrowsingEnabled(enabled);
+}
+
+- (BOOL)isSafeBrowsingEnabled
+{
+    return _preferences->safeBrowsingEnabled();
+}
+
 #pragma mark OS X-specific methods
 
@@ -696 +706 @@
 {
     _preferences->setICECandidateFilteringEnabled(enabled);
-}
-
-- (void)setSafeBrowsingEnabled:(BOOL)enabled
-{
-    _preferences->setSafeBrowsingEnabled(enabled);
-}
-
-- (BOOL)isSafeBrowsingEnabled
-{
-    return _preferences->safeBrowsingEnabled();
 }