Changeset 238456 in webkit

Timestamp:

Nov 22, 2018, 8:36:38 PM (8 years ago)

Author:

Chris Dumez

Message:

Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation
​https://bugs.webkit.org/show_bug.cgi?id=191914

Reviewed by Ryosuke Niwa.

Source/WebKit:

When process-swapping on a cross-site server-side redirect, we end up doing a decidePolicyForNavigationResponse
policy check for the about:blank suspension load. This policy decision is ignored by the UIProcess because
SuspendedPageProxy does not handle this particular IPC message. To handle the issue, make sure the WebProcess
never sends a DecidePolicyForNavigationResponse IPC to the UIProcess for about:blank suspension loads and let
the load proceed.

The issue was already there before r238353 but it was made obvious by r238353 which caused a hang when trying
to reuse a Suspended page which is hanging while trying to suspend.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-11-22  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation
+        https://bugs.webkit.org/show_bug.cgi?id=191914
+
+        Reviewed by Ryosuke Niwa.
+
+        When process-swapping on a cross-site server-side redirect, we end up doing a decidePolicyForNavigationResponse
+        policy check for the about:blank suspension load. This policy decision is ignored by the UIProcess because
+        SuspendedPageProxy does not handle this particular IPC message. To handle the issue, make sure the WebProcess
+        never sends a DecidePolicyForNavigationResponse IPC to the UIProcess for about:blank suspension loads and let
+        the load proceed.
+
+        The issue was already there before r238353 but it was made obvious by r238353 which caused a hang when trying
+        to reuse a Suspended page which is hanging while trying to suspend.
+
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
+
 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

@@ -739 +739 @@
     }
 
+    // For suspension loads to about:blank, no need to ask the SuspendedPageProxy.
+    if (request.url() == blankURL() && webPage->isSuspended()) {
+        function(PolicyAction::Use);
+        return;
+    }
+
     RefPtr<API::Object> userData;
 

trunk/Tools/ChangeLog

@@ +1 @@
+2018-11-22  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation
+        https://bugs.webkit.org/show_bug.cgi?id=191914
+
+        Reviewed by Ryosuke Niwa.
+
+        Add API test coverage.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
 2018-11-22  Zalan Bujtas  <zalan@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

@@ -1320 +1320 @@
     EXPECT_EQ(3, numberOfDecidePolicyCalls);
     EXPECT_EQ(2u, seenPIDs.size());
+
+    EXPECT_WK_STREQ(@"pson://www.apple.com/main.html", [[webView URL] absoluteString]);
+
+    [webView goBack];
+
+    TestWebKitAPI::Util::run(&done);
+    done = false;
+
+    EXPECT_WK_STREQ(@"pson://www.webkit.org/main1.html", [[webView URL] absoluteString]);
 }