Changeset 238462 in webkit

Timestamp:

Nov 23, 2018, 11:45:52 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Scrollbars not following gtk-primary-button-warps-slider setting
​https://bugs.webkit.org/show_bug.cgi?id=191067

Updated code per the style guide, removed unreachable break (non-semantic change)

Patch by Jim Mason <​jmason@ibinx.com> on 2018-11-23
Reviewed by Michael Catanzaro.

• platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::handleMousePressEvent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/ScrollbarThemeGtk.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-11-23  Jim Mason  <jmason@ibinx.com>
+
+        [GTK] Scrollbars not following gtk-primary-button-warps-slider setting
+        https://bugs.webkit.org/show_bug.cgi?id=191067
+
+        Updated code per the style guide, removed unreachable break (non-semantic change)
+
+        Reviewed by Michael Catanzaro.
+
+        * platform/gtk/ScrollbarThemeGtk.cpp:
+        (WebCore::ScrollbarThemeGtk::handleMousePressEvent):
+
 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp

@@ -773 +773 @@
 ScrollbarButtonPressAction ScrollbarThemeGtk::handleMousePressEvent(Scrollbar&, const PlatformMouseEvent& event, ScrollbarPart pressedPart)
 {
-    gboolean warp_slider = FALSE;
+    gboolean warpSlider = FALSE;
     switch (pressedPart) {
     case BackTrackPart:
@@ -779 +779 @@
         g_object_get(gtk_settings_get_default(),
             "gtk-primary-button-warps-slider",
-            &warp_slider, nullptr);
+            &warpSlider, nullptr);
         // The shift key or middle/right button reverses the sense.
         if (event.shiftKey() || event.button() != LeftButton)
-            warp_slider = !warp_slider;
-        return warp_slider ?
+            warpSlider = !warpSlider;
+        return warpSlider ?
             ScrollbarButtonPressAction::CenterOnThumb:
             ScrollbarButtonPressAction::Scroll;
-        break;
     case ThumbPart:
         if (event.button() != RightButton)