Changeset 238464 in webkit

Timestamp:

Nov 23, 2018, 2:06:35 PM (8 years ago)

Author:

rniwa@webkit.org

Message:

Updating href on textPath doesn't update its rendering
​https://bugs.webkit.org/show_bug.cgi?id=191920

Reviewed by Dean Jackson.

Source/WebCore:

Fixed the bug by invalidating the RenderSVGResource in SVGTextPathElement::svgAttributeChanged
in addition to updating the pending resources.

Test: svg/text/textpath-reference-update.html

• svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::svgAttributeChanged):

LayoutTests:

Added a ref test.

• svg/text/textpath-reference-update-expected.html: Added.
• svg/text/textpath-reference-update.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/text/textpath-reference-update-expected.html (added)
• LayoutTests/svg/text/textpath-reference-update.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGTextPathElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-11-22  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Updating href on textPath doesn't update its rendering
+        https://bugs.webkit.org/show_bug.cgi?id=191920
+
+        Reviewed by Dean Jackson.
+
+        Added a ref test.
+
+        * svg/text/textpath-reference-update-expected.html: Added.
+        * svg/text/textpath-reference-update.html: Added.
+
 2018-11-23  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-11-22  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Updating href on textPath doesn't update its rendering
+        https://bugs.webkit.org/show_bug.cgi?id=191920
+
+        Reviewed by Dean Jackson.
+
+        Fixed the bug by invalidating the RenderSVGResource in SVGTextPathElement::svgAttributeChanged
+        in addition to updating the pending resources.
+
+        Test: svg/text/textpath-reference-update.html
+
+        * svg/SVGTextPathElement.cpp:
+        (WebCore::SVGTextPathElement::svgAttributeChanged):
+
 2018-11-23  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/WebCore/svg/SVGTextPathElement.cpp

@@ -104 +104 @@
     if (SVGURIReference::isKnownAttribute(attrName)) {
         buildPendingResource();
+        if (auto renderer = this->renderer())
+            RenderSVGResource::markForLayoutAndParentResourceInvalidation(*renderer);
         return;
     }