⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 238483 in webkit


Ignore:
Timestamp:
Nov 25, 2018, 1:44:43 PM (8 years ago)
Author:
Matt Baker
Message:

Web Inspector: Remove parameters from TreeOutline SelectionDidChange event
​https://bugs.webkit.org/show_bug.cgi?id=191770

Reviewed by Devin Rousso.

  • UserInterface/Controllers/CallFrameTreeController.js:

(WI.CallFrameTreeController.prototype._treeSelectionDidChange):

  • UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype._treeSelectionDidChange):

  • UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel):
(WI.CanvasSidebarPanel.prototype._treeSelectionDidChange):
(WI.CanvasSidebarPanel.prototype._treeOutlineSelectionDidChange): Deleted.

  • UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype._canvasTreeOutlineSelectionDidChange):

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel.prototype._treeSelectionDidChange):

  • UserInterface/Views/OpenResourceDialog.js:

(WI.OpenResourceDialog.prototype._treeSelectionDidChange):

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):

  • UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype._treeSelectionDidChange):

  • UserInterface/Views/StorageSidebarPanel.js:

(WI.StorageSidebarPanel._treeSelectionDidChange):

  • UserInterface/Views/TimelineDataGrid.js:

(WI.TimelineDataGrid.prototype._popoverCallStackTreeSelectionDidChange):
(WI.TimelineDataGrid):

  • UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView.prototype._recordingsTreeSelectionDidChange):
Use event.target.selectedTreeElement instead of event.data.selectedElement.

  • UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype._timelinesTreeSelectionDidChange):
(WI.TimelineOverview.prototype._timelinesTreeSelectionDidChange.updateGraphSelectedState): Deleted.
Refactor away the single place event.data.deselectedElement was used.

  • UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype.select):
(WI.TreeElement.prototype.deselect):
Remove selectedElement and deselectedElement from event data.

Location:
trunk/Source/WebInspectorUI
Files:
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r238385 r238483  
     12018-11-25  Matt Baker  <mattbaker@apple.com>
     2
     3        Web Inspector: Remove parameters from TreeOutline SelectionDidChange event
     4        https://bugs.webkit.org/show_bug.cgi?id=191770
     5
     6        Reviewed by Devin Rousso.
     7
     8        * UserInterface/Controllers/CallFrameTreeController.js:
     9        (WI.CallFrameTreeController.prototype._treeSelectionDidChange):
     10        * UserInterface/Views/AuditNavigationSidebarPanel.js:
     11        (WI.AuditNavigationSidebarPanel.prototype._treeSelectionDidChange):
     12        * UserInterface/Views/CanvasSidebarPanel.js:
     13        (WI.CanvasSidebarPanel):
     14        (WI.CanvasSidebarPanel.prototype._treeSelectionDidChange):
     15        (WI.CanvasSidebarPanel.prototype._treeOutlineSelectionDidChange): Deleted.
     16        * UserInterface/Views/CanvasTabContentView.js:
     17        (WI.CanvasTabContentView.prototype._canvasTreeOutlineSelectionDidChange):
     18        * UserInterface/Views/DebuggerSidebarPanel.js:
     19        (WI.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
     20        * UserInterface/Views/OpenResourceDialog.js:
     21        (WI.OpenResourceDialog.prototype._treeSelectionDidChange):
     22        * UserInterface/Views/ResourceSidebarPanel.js:
     23        (WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):
     24        * UserInterface/Views/SearchSidebarPanel.js:
     25        (WI.SearchSidebarPanel.prototype._treeSelectionDidChange):
     26        * UserInterface/Views/StorageSidebarPanel.js:
     27        (WI.StorageSidebarPanel._treeSelectionDidChange):
     28        * UserInterface/Views/TimelineDataGrid.js:
     29        (WI.TimelineDataGrid.prototype._popoverCallStackTreeSelectionDidChange):
     30        (WI.TimelineDataGrid):
     31        * UserInterface/Views/TimelineTabContentView.js:
     32        (WI.TimelineTabContentView.prototype._recordingsTreeSelectionDidChange):
     33        Use `event.target.selectedTreeElement` instead of `event.data.selectedElement`.
     34
     35        * UserInterface/Views/TimelineOverview.js:
     36        (WI.TimelineOverview.prototype._timelinesTreeSelectionDidChange):
     37        (WI.TimelineOverview.prototype._timelinesTreeSelectionDidChange.updateGraphSelectedState): Deleted.
     38        Refactor away the single place `event.data.deselectedElement` was used.
     39
     40        * UserInterface/Views/TreeElement.js:
     41        (WI.TreeElement.prototype.select):
     42        (WI.TreeElement.prototype.deselect):
     43        Remove `selectedElement` and `deselectedElement` from event data.
     44
    1452018-11-19  Devin Rousso  <drousso@apple.com>
    246

  • trunk/Source/WebInspectorUI/UserInterface/Controllers/CallFrameTreeController.js

    r235873 r238483  
    7777    _treeSelectionDidChange(event)
    7878    {
    79         this._showSourceCodeLocation(event.data.selectedElement);
     79        this._showSourceCodeLocation(this._treeOutline.selectedTreeElement);
    8080    }
    8181

  • trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js

    r238334 r238483  
    194194            return;
    195195
    196         let treeElement = event.data.selectedElement;
     196        let treeElement = this.contentTreeOutline.selectedTreeElement;
    197197        if (!treeElement || treeElement instanceof WI.FolderTreeElement) {
    198198            this.showDefaultContentView();

  • trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js

    r238198 r238483  
    7373        this._recordingTreeOutline.registerScrollVirtualizer(this._recordingContentContainer, 20);
    7474
    75         this._canvasTreeOutline.addEventListener(WI.TreeOutline.Event.SelectionDidChange, this._treeOutlineSelectionDidChange, this);
    76         this._recordingTreeOutline.addEventListener(WI.TreeOutline.Event.SelectionDidChange, this._treeOutlineSelectionDidChange, this);
     75        this._canvasTreeOutline.addEventListener(WI.TreeOutline.Event.SelectionDidChange, this._treeSelectionDidChange, this);
     76        this._recordingTreeOutline.addEventListener(WI.TreeOutline.Event.SelectionDidChange, this._treeSelectionDidChange, this);
    7777
    7878        this._recordingProcessingOptionsContainer = null;
    … …  
    313313    }
    314314
    315     _treeOutlineSelectionDidChange(event)
    316     {
    317         let treeElement = event.data.selectedElement;
     315    _treeSelectionDidChange(event)
     316    {
     317        let treeElement = event.target.selectedTreeElement;
    318318        if (!treeElement)
    319319            return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js

    r238198 r238483  
    240240    _canvasTreeOutlineSelectionDidChange(event)
    241241    {
    242         let selectedElement = event.data.selectedElement;
     242        let selectedElement = this._canvasTreeOutline.selectedTreeElement;
    243243        if (!selectedElement)
    244244            return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js

    r238202 r238483  
    910910            return;
    911911
    912         let treeElement = event.data.selectedElement;
     912        let treeElement = event.target.selectedTreeElement;
    913913        if (!treeElement)
    914914            return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js

    r237327 r238483  
    263263    _treeSelectionDidChange(event)
    264264    {
    265         let treeElement = event.data.selectedElement;
     265        let treeElement = this._treeOutline.selectedTreeElement;
    266266        if (!treeElement)
    267267            return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js

    r238017 r238483  
    458458            return;
    459459
    460         let treeElement = event.data.selectedElement;
     460        let treeElement = this.contentTreeOutline.selectedTreeElement;
    461461        if (!treeElement)
    462462            return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js

    r236766 r238483  
    377377            return;
    378378
    379         let treeElement = event.data.selectedElement;
     379        let treeElement = this.contentTreeOutline.selectedTreeElement;
    380380        if (!treeElement || treeElement instanceof WI.FolderTreeElement)
    381381            return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js

    r237593 r238483  
    174174            return;
    175175
    176         let treeElement = event.data.selectedElement;
     176        let treeElement = this.contentTreeOutline.selectedTreeElement;
    177177        if (!treeElement)
    178178            return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js

    r235997 r238483  
    417417    _popoverCallStackTreeSelectionDidChange(event)
    418418    {
    419         let treeElement = event.data.selectedElement;
     419        let treeElement = this._popoverCallStackTreeOutline.selectedTreeElement;
    420420        if (!treeElement)
    421421            return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

    r237195 r238483  
    843843    _timelinesTreeSelectionDidChange(event)
    844844    {
    845         function updateGraphSelectedState(timeline, selected)
    846         {
    847             let overviewGraph = this._overviewGraphsByTypeMap.get(timeline.type);
    848             console.assert(overviewGraph, "Missing overview graph for timeline", timeline);
    849             overviewGraph.selected = selected;
    850         }
    851 
    852         let selectedTreeElement = event.data.selectedElement;
    853         let deselectedTreeElement = event.data.deselectedElement;
    854845        let timeline = null;
     846        let selectedTreeElement = this._timelinesTreeOutline.selectedTreeElement;
    855847        if (selectedTreeElement) {
    856848            timeline = selectedTreeElement.representedObject;
    … …  
    858850            console.assert(this._recording.timelines.get(timeline.type) === timeline, timeline);
    859851
    860             updateGraphSelectedState.call(this, timeline, true);
    861         }
    862 
    863         if (deselectedTreeElement)
    864             updateGraphSelectedState.call(this, deselectedTreeElement.representedObject, false);
     852            for (let [type, overviewGraph] of this._overviewGraphsByTypeMap)
     853                overviewGraph.selected = type === timeline.type;
     854        }
    865855
    866856        this._selectedTimeline = timeline;

  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js

    r228024 r238483  
    422422    _recordingsTreeSelectionDidChange(event)
    423423    {
    424         let treeElement = event.data.selectedElement;
     424        let treeElement = this._recordingsTreeOutline.selectedTreeElement;
    425425        if (!treeElement)
    426426            return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js

    r235377 r238483  
    528528
    529529        // Prevent dispatching a SelectionDidChange event for the deselected element if
    530         // it will be dispatched for the selected element. The event data includes both
    531         // the selected and deselected elements, so one event is.
     530        // it will be dispatched for the selected element.
    532531        if (!suppressOnSelect)
    533532            suppressOnDeselect = true;
    … …  
    549548                this.onselect(this, selectedByUser);
    550549
    551             treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.SelectionDidChange, {selectedElement: this, deselectedElement, selectedByUser});
     550            treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.SelectionDidChange, {selectedByUser});
    552551        }
    553552
    … …  
    582581                this.ondeselect(this);
    583582
    584             this.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.SelectionDidChange, {deselectedElement: this});
     583            this.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.SelectionDidChange);
    585584        }
    586585
Note: See TracChangeset for help on using the changeset viewer.