Changeset 238532 in webkit

Timestamp:

Nov 26, 2018, 4:48:51 PM (8 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Add field in Patch object to indicate if it has been sent to Buildbot
​https://bugs.webkit.org/show_bug.cgi?id=191929

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/models/patch.py:

(Patch): Added sent_to_buildbot field.
(Patch.is_patch_sent_to_buildbot): Checks if the patch has been sent to Buildbot.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/models/patch.py (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/models/patch.py

@@ -36 +36 @@
     bug_id = models.IntegerField()
     obsolete = models.BooleanField(default=False)
+    sent_to_buildbot = models.BooleanField(default=False)
     created = models.DateTimeField(auto_now_add=True)
     modified = models.DateTimeField(auto_now=True)
@@ -43 +44 @@
 
     @classmethod
-    def save_patch(cls, patch_id, bug_id=-1, obsolete=False):
+    def save_patch(cls, patch_id, bug_id=-1, obsolete=False, sent_to_buildbot=False):
         if not Patch.is_valid_patch_id(patch_id):
             return ERR_INVALID_PATCH_ID
@@ -50 +51 @@
             _log.info("Patch id {} already exists in database. Skipped saving.".format(patch_id))
             return ERR_EXISTING_PATCH
-        Patch(patch_id, bug_id, obsolete).save()
+        Patch(patch_id, bug_id, obsolete, sent_to_buildbot).save()
         _log.info('Saved patch in database, id: {}'.format(patch_id))
         return SUCCESS
@@ -69 +70 @@
     def is_existing_patch_id(cls, patch_id):
         return bool(Patch.objects.filter(patch_id=patch_id))
+
+    @classmethod
+    def is_patch_sent_to_buildbot(cls, patch_id):
+        return Patch.is_existing_patch_id(patch_id) and Patch.objects.get(pk=patch_id).sent_to_buildbot

trunk/Tools/ChangeLog

@@ +1 @@
+2018-11-26  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Add field in Patch object to indicate if it has been sent to Buildbot
+        https://bugs.webkit.org/show_bug.cgi?id=191929
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/models/patch.py:
+        (Patch): Added sent_to_buildbot field.
+        (Patch.is_patch_sent_to_buildbot): Checks if the patch has been sent to Buildbot.
+
 2018-11-26  Aakash Jain  <aakash_jain@apple.com>