Changeset 238534 in webkit

Timestamp:

Nov 26, 2018, 5:02:42 PM (8 years ago)

Author:

Jonathan Bedard

Message:

webkitpy: Race condition in ServerProcess tests
​https://bugs.webkit.org/show_bug.cgi?id=191989
<rdar://problem/45536844>

Reviewed by Lucas Forschler.

Serializing these tests to prevent the race conditions.

• Scripts/webkitpy/port/server_process_unittest.py:

(TestServerProcess.serial_test_basic):
(TestServerProcess.serial_test_read_after_process_exits):
(TestServerProcess.serial_test_process_crashing):
(TestServerProcess.serial_test_process_crashing_no_data):
(TestServerProcess.test_basic): Deleted.
(TestServerProcess.test_read_after_process_exits): Deleted.
(TestServerProcess.test_process_crashing): Deleted.
(TestServerProcess.test_process_crashing_no_data): Deleted.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/server_process_unittest.py (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-11-26  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Race condition in ServerProcess tests
+        https://bugs.webkit.org/show_bug.cgi?id=191989
+        <rdar://problem/45536844>
+
+        Reviewed by Lucas Forschler.
+
+        Serializing these tests to prevent the race conditions.
+
+        * Scripts/webkitpy/port/server_process_unittest.py:
+        (TestServerProcess.serial_test_basic):
+        (TestServerProcess.serial_test_read_after_process_exits):
+        (TestServerProcess.serial_test_process_crashing):
+        (TestServerProcess.serial_test_process_crashing_no_data):
+        (TestServerProcess.test_basic): Deleted.
+        (TestServerProcess.test_read_after_process_exits): Deleted.
+        (TestServerProcess.test_process_crashing): Deleted.
+        (TestServerProcess.test_process_crashing_no_data): Deleted.
+
 2018-11-26  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/server_process_unittest.py

@@ -99 +99 @@
 
 class TestServerProcess(unittest.TestCase):
-    def test_basic(self):
+    def serial_test_basic(self):
         # Give -u switch to force stdout and stderr to be unbuffered for Windows
         cmd = [sys.executable, '-uc', 'import sys; print "stdout"; print >>sys.stderr, "stderr"; sys.stdin.readline();']
@@ -129 +129 @@
         proc.stop(0)
 
-    def test_read_after_process_exits(self):
+    def serial_test_read_after_process_exits(self):
         cmd = [sys.executable, '-c', 'import sys; print "stdout"; print >>sys.stderr, "stderr";']
         host = SystemHost()
@@ -147 +147 @@
         proc.stop(0)
 
-    def test_process_crashing(self):
+    def serial_test_process_crashing(self):
         # Give -u switch to force stdout to be unbuffered for Windows
         cmd = [sys.executable, '-uc', 'import sys; print "stdout 1"; print "stdout 2"; print "stdout 3"; sys.stdin.readline(); sys.exit(1);']
@@ -173 +173 @@
         proc.stop(0)
 
-    def test_process_crashing_no_data(self):
+    def serial_test_process_crashing_no_data(self):
         cmd = [sys.executable, '-c',
                'import sys; sys.stdin.readline(); sys.exit(1);']