⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 238540 in webkit


Ignore:
Timestamp:
Nov 26, 2018, 5:59:19 PM (8 years ago)
Author:
Ryan Haddad
Message:

Unreviewed, rolling out r238357.

One of the layout tests added with this change is failing on Mojave.

Reverted changeset:
"REGRESSION (r238078): Do not draw caps lock indicator when Strong Password button is shown"
​https://bugs.webkit.org/show_bug.cgi?id=191969
​https://trac.webkit.org/changeset/238513

Location:
trunk
Files:
4 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r238538 r238540  
     12018-11-26  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, rolling out r238357.
     4
     5        One of the layout tests added with this change is failing on Mojave.
     6
     7        Reverted changeset:
     8        "REGRESSION (r238078): Do not draw caps lock indicator when Strong Password button is shown"
     9        https://bugs.webkit.org/show_bug.cgi?id=191969
     10        https://trac.webkit.org/changeset/238513
     11
    1122018-11-26  Tim Horton  <timothy_horton@apple.com>
    213

  • trunk/LayoutTests/TestExpectations

    r238522 r238540  
    400400
    401401fast/events/detect-caps-lock.html [ Skip ]
    402 fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button.html [ Skip ]
    403 fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible.html [ Skip ]
    404402fast/repaint/placeholder-after-caps-lock-hidden.html [ Skip ]
    405403fast/forms/password-scrolled-after-caps-lock-toggled.html [ Skip ]

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r238522 r238540  
    6969
    7070[ Mojave+ ] fast/events/detect-caps-lock.html [ Pass ]
    71 [ Mojave+ ] fast/forms/auto-fill-button/caps-lock-indicator-should-be-visible-when-after-hiding-auto-fill-strong-password-button.html [ Pass ]
    72 [ Mojave+ ] fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible.html [ Pass ]
    7371[ Mojave+ ] fast/repaint/placeholder-after-caps-lock-hidden.html [ Pass ]
    7472[ Mojave+ ] fast/forms/password-scrolled-after-caps-lock-toggled.html [ Pass ]

  • trunk/Source/WebCore/ChangeLog

    r238538 r238540  
     12018-11-26  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, rolling out r238357.
     4
     5        One of the layout tests added with this change is failing on Mojave.
     6
     7        Reverted changeset:
     8        "REGRESSION (r238078): Do not draw caps lock indicator when Strong Password button is shown"
     9        https://bugs.webkit.org/show_bug.cgi?id=191969
     10        https://trac.webkit.org/changeset/238513
     11
    1122018-11-26  Tim Horton  <timothy_horton@apple.com>
    213

  • trunk/Source/WebCore/html/TextFieldInputType.cpp

    r238513 r238540  
    725725        return false;
    726726
    727     if (element()->hasAutoFillStrongPasswordButton())
    728         return false;
    729 
    730727    RefPtr<Frame> frame = element()->document().frame();
    731728    if (!frame)
    … …  
    796793void TextFieldInputType::updateAutoFillButton()
    797794{
    798     capsLockStateMayHaveChanged();
    799 
    800795    if (shouldDrawAutoFillButton()) {
    801796        if (!m_container)
Note: See TracChangeset for help on using the changeset viewer.